Skip to content

Conversation

@sm745052
Copy link
Contributor

No description provided.

@sm745052 sm745052 requested a review from a team as a code owner December 15, 2025 06:58
@sm745052 sm745052 requested a review from darshan-sj December 15, 2025 06:58
@gemini-code-assist
Copy link

Summary of Changes

Hello @sm745052, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the data pipeline by introducing a table-level configuration for the JDBC fetch size. This modification provides more granular control over how data is retrieved from source databases, allowing for performance optimization on a per-table basis. The changes involve updating the TableConfig to include this new parameter and adjusting the JdbcIoWrapper to leverage this table-specific setting during data processing.

Highlights

  • Table-level Fetch Size Configuration: Introduced a new fetchSize parameter within the TableConfig class, allowing for specific fetch size settings per table rather than a global configuration.
  • Integration into JDBC I/O Wrapper: The JdbcIoWrapper now correctly reads and applies the fetchSize from the TableConfig object when configuring JDBC I/O operations, ensuring the table-specific setting is utilized.
  • Default Null Fetch Size: The TableConfig builder has been updated to initialize fetchSize to null by default, making it an optional parameter that can be set when needed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 20.68966% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.03%. Comparing base (4a4a597) to head (ae1f6c7).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...dbc/rowmapper/provider/MysqlJdbcValueMappings.java 0.00% 36 Missing ⚠️
...owmapper/provider/PostgreSQLJdbcValueMappings.java 0.00% 34 Missing ⚠️
.../reader/io/jdbc/iowrapper/FetchSizeCalculator.java 60.00% 7 Missing and 3 partials ⚠️
...jdbc/dialectadapter/mysql/MysqlDialectAdapter.java 0.00% 6 Missing ⚠️
...ctadapter/postgresql/PostgreSQLDialectAdapter.java 0.00% 6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (20.68%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3109      +/-   ##
============================================
+ Coverage     50.79%   56.03%   +5.23%     
+ Complexity     5106     1713    -3393     
============================================
  Files           975      474     -501     
  Lines         59984    26780   -33204     
  Branches       6552     2825    -3727     
============================================
- Hits          30468    15005   -15463     
+ Misses        27375    10878   -16497     
+ Partials       2141      897    -1244     
Components Coverage Δ
spanner-templates 71.83% <20.68%> (+0.85%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 80.00% <ø> (-0.04%) ⬇️
spanner-live-reverse-replication 77.71% <ø> (+0.06%) ⬆️
spanner-bulk-migration 87.76% <20.68%> (-0.72%) ⬇️
Files with missing lines Coverage Δ
.../reader/io/jdbc/dialectadapter/DialectAdapter.java 100.00% <ø> (ø)
...source/reader/io/jdbc/iowrapper/JdbcIoWrapper.java 93.15% <100.00%> (+0.14%) ⬆️
...e/reader/io/jdbc/iowrapper/config/TableConfig.java 100.00% <100.00%> (ø)
...jdbc/dialectadapter/mysql/MysqlDialectAdapter.java 97.59% <0.00%> (-2.06%) ⬇️
...ctadapter/postgresql/PostgreSQLDialectAdapter.java 93.98% <0.00%> (-3.21%) ⬇️
.../reader/io/jdbc/iowrapper/FetchSizeCalculator.java 60.00% <60.00%> (ø)
...owmapper/provider/PostgreSQLJdbcValueMappings.java 70.54% <0.00%> (-25.25%) ⬇️
...dbc/rowmapper/provider/MysqlJdbcValueMappings.java 72.30% <0.00%> (-11.03%) ⬇️

... and 527 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

VardhanThigle
VardhanThigle previously approved these changes Dec 15, 2025
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants