Iam test

[pratickchokhani]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @pratickchokhani, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a robust IAM permission validation mechanism into the Cloud Spanner Export and Import Dataflow pipelines. The core purpose is to ensure that the service account executing these pipelines possesses all required permissions on the specified Spanner instances and databases before any data processing begins. This proactive validation aims to improve pipeline reliability by catching permission-related configuration errors early, thereby preventing costly failures during execution.

Highlights

• IAM Permission Validation Framework: Introduced a new framework for validating Identity and Access Management (IAM) permissions required by the Spanner Export and Import pipelines. This framework allows for pre-execution checks to ensure the necessary permissions are in place.
• Pre-execution Permission Checks: The Spanner Export pipeline now performs a read permission check on the target Spanner database before starting, and the Spanner Import pipeline performs a write permission check. This helps in failing early if permissions are insufficient.
• New IAM Utility Classes: Added several new utility classes (IAMCheckResult, IAMPermissionsChecker, IAMRequirementsCreator, IAMResourceRequirements) to manage and perform IAM permission checks in a structured manner.
• Dependency Update: Added a new Maven dependency for google-api-services-cloudresourcemanager to enable interaction with the Cloud Resource Manager API for permission checks.
• Hardcoded Project ID in Import Checks: The IAM permission checks for the Spanner Import pipeline currently use a hardcoded project ID ('span-cloud-migrations-testing') when instantiating the IAMPermissionsChecker. This may need to be parameterized for broader applicability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

❌ Patch coverage is 28.12500% with 69 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.75%. Comparing base (4e8bd77) to head (f8bf616).
⚠️ Report is 41 commits behind head on main.

Files with missing lines	Patch %	Lines
.../google/cloud/teleport/spanner/ImportPipeline.java	0.00%	24 Missing ⚠️
.../google/cloud/teleport/spanner/ExportPipeline.java	0.00%	20 Missing ⚠️
...d/teleport/spanner/iam/IAMRequirementsCreator.java	0.00%	10 Missing ⚠️
...google/cloud/teleport/spanner/ImportTransform.java	0.00%	7 Missing ⚠️
...ud/teleport/spanner/iam/IAMPermissionsChecker.java	80.76%	5 Missing ⚠️
...gle/cloud/teleport/spanner/iam/IAMCheckResult.java	66.66%	3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (28.12%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3138      +/-   ##
============================================
+ Coverage     50.41%   50.75%   +0.34%     
- Complexity     5022     5113      +91     
============================================
  Files           970      977       +7     
  Lines         59609    60063     +454     
  Branches       6507     6553      +46     
============================================
+ Hits          30050    30485     +435     
  Misses        27436    27436              
- Partials       2123     2142      +19     

Components	Coverage Δ
spanner-templates	70.81% <28.12%> (+0.16%)	⬆️
spanner-import-export	68.53% <28.12%> (-0.46%)	⬇️
spanner-live-forward-migration	80.04% <ø> (+0.01%)	⬆️
spanner-live-reverse-replication	77.73% <ø> (+0.26%)	⬆️
spanner-bulk-migration	88.46% <ø> (+0.21%)	⬆️

Files with missing lines	Coverage Δ
...com/google/cloud/teleport/spanner/ReadDialect.java	0.00% <ø> (ø)
...gle/cloud/teleport/spanner/iam/IAMCheckResult.java	66.66% <66.66%> (ø)
...ud/teleport/spanner/iam/IAMPermissionsChecker.java	80.76% <80.76%> (ø)
...google/cloud/teleport/spanner/ImportTransform.java	21.95% <0.00%> (-0.30%)	⬇️
...d/teleport/spanner/iam/IAMRequirementsCreator.java	0.00% <0.00%> (ø)
.../google/cloud/teleport/spanner/ExportPipeline.java	0.00% <0.00%> (ø)
.../google/cloud/teleport/spanner/ImportPipeline.java	0.00% <0.00%> (ø)

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bharadwaj-aditya]

This validation will happen after the pipeline starts, which is going to be pretty similar to running the import itself.