Skip to content

Conversation

@nmemond
Copy link
Contributor

@nmemond nmemond commented Dec 22, 2025

This adds some missing data type mappings to the existing data type integration test, and also adds a test for a migration to a postgres dialect spanner instance.

Note that some of the type mappings fail to migrate as expected. The checks for those are still included for completeness, but they're commented out to avoid failing the tests.

@gemini-code-assist
Copy link

Summary of Changes

Hello @nmemond, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the integration test coverage for the bulk Spanner migration template. It ensures that various data types from both MySQL and PostgreSQL source databases are correctly migrated to Spanner, including support for the PostgreSQL dialect. The changes involve adding new test cases for type conversions and validating the migration behavior for both supported and currently unsupported data types, thereby improving the robustness and reliability of the migration process.

Highlights

  • PostgreSQL Dialect Spanner Integration Tests: Introduced new integration tests to verify data type migration from MySQL and PostgreSQL databases to a PostgreSQL dialect Spanner instance.
  • Expanded MySQL Data Type Coverage: Added numerous new data type mappings and conversion tests (e.g., _to_string, _to_bool, _to_int64, _to_numeric, _to_float64, _to_float32) to the existing MySQL data types integration test suite.
  • Enhanced PostgreSQL Data Type Coverage: Expanded the PostgreSQL data types integration test with new type-conversion mappings and updated the list of unsupported types, explicitly commenting out those that currently fail migration.
  • Resource Manager Update: Added a new method to set up a Spanner resource manager specifically configured for PostgreSQL dialect instances, facilitating testing against this new target.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.11%. Comparing base (1d3183c) to head (12e15a7).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3144      +/-   ##
============================================
+ Coverage     50.78%   56.11%   +5.33%     
+ Complexity     5103     1695    -3408     
============================================
  Files           975      472     -503     
  Lines         59984    26679   -33305     
  Branches       6552     2806    -3746     
============================================
- Hits          30461    14971   -15490     
+ Misses        27380    10810   -16570     
+ Partials       2143      898    -1245     
Components Coverage Δ
spanner-templates 72.10% <ø> (+1.13%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 80.02% <ø> (-0.02%) ⬇️
spanner-live-reverse-replication 77.58% <ø> (-0.02%) ⬇️
spanner-bulk-migration 88.47% <ø> (-0.04%) ⬇️
see 524 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nmemond nmemond force-pushed the pg-data-type-tests-bulk branch from 3a4f765 to 2e8f69f Compare December 23, 2025 14:24
@nmemond nmemond force-pushed the pg-data-type-tests-bulk branch from 2e8f69f to 12e15a7 Compare December 24, 2025 14:11
@nmemond nmemond marked this pull request as ready for review December 24, 2025 14:11
@nmemond nmemond requested a review from a team as a code owner December 24, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants