-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add integration tests to bulk spanner migration for checking PostgreSQL data type support #3144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @nmemond, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the integration test coverage for the bulk Spanner migration template. It ensures that various data types from both MySQL and PostgreSQL source databases are correctly migrated to Spanner, including support for the PostgreSQL dialect. The changes involve adding new test cases for type conversions and validating the migration behavior for both supported and currently unsupported data types, thereby improving the robustness and reliability of the migration process. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3144 +/- ##
============================================
+ Coverage 50.78% 56.11% +5.33%
+ Complexity 5103 1695 -3408
============================================
Files 975 472 -503
Lines 59984 26679 -33305
Branches 6552 2806 -3746
============================================
- Hits 30461 14971 -15490
+ Misses 27380 10810 -16570
+ Partials 2143 898 -1245
🚀 New features to boost your workflow:
|
3a4f765 to
2e8f69f
Compare
2e8f69f to
12e15a7
Compare
This adds some missing data type mappings to the existing data type integration test, and also adds a test for a migration to a postgres dialect spanner instance.
Note that some of the type mappings fail to migrate as expected. The checks for those are still included for completeness, but they're commented out to avoid failing the tests.