resolve IAM groups, membership in iam.py-issue34 - #114
Open
kaushik853 wants to merge 5 commits into
Open
Conversation
added new function _get_group_members and modified the _expand_policy
ebenezergraham
requested changes
Mar 26, 2025
|
|
||
| processed_groups.add(group_email) | ||
|
|
||
| service = googleapiclient.discovery.build('cloudidentity', 'v1', cache_discovery=False) |
Collaborator
There was a problem hiding this comment.
Use apis.get_api() to build the client.
Contributor
Author
There was a problem hiding this comment.
Use apis.get_api() to build the client.
modified it
Collaborator
|
Thanks for the merge request @kaushik853 We will be pushing a new release shortly that should integrate your changes. |
Contributor
Author
|
Collaborator
|
We just released a new version which should include your merged changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added new function _get_group_members and modified the _expand_policy.
_get_group_members function resolves group using the Google Cloud IAM API to list members of groups.
Modify the _expand_policy method to also handle groups by resolving group memberships recursively and include them in the expanded policy.