feat(gce): add boot disk auto-delete warning rule - #148
Open
gokulr94 wants to merge 2 commits into
Open
Conversation
gokulr94
marked this pull request as ready for review
January 20, 2026 17:00
gokulr94
force-pushed
the
main
branch
2 times, most recently
from
January 22, 2026 05:21
a148f25 to
abf3184
Compare
Add WARN/2026_001 to check if boot disks have auto-delete enabled. When disabled, VMs leave orphaned disks after deletion, causing unexpected storage costs. - Skips GKE and Dataproc managed instances - Reports warning for boot disks with autoDelete=false
The error message for missing instanceTemplate was not interpolating
the MIG name due to missing f-string prefix. This caused the literal
string '{self.name}' to be shown instead of the actual MIG name.
Author
|
Hi, could you please approve the workflow run? I added an additional commit with a fix for a missing f-string prefix in the MIG template error message (gce.py:241). The string was not interpolating the MIG name correctly. Changes in this PR:
Both changes have been tested locally - all GCE tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add WARN/2026_001 to check if boot disks have auto-delete enabled. When disabled, VMs leave orphaned disks after deletion, causing unexpected storage costs.