-
Notifications
You must be signed in to change notification settings - Fork 1
[REFACTOR] - Refactor audio player service architecture #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
atlet99
wants to merge
598
commits into
main
Choose a base branch
from
feature/beta_1.2.7
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d error handling;
…ectors and a robust row validation strategy;
…creen UI with icons, improved spacing, and animated loading state;
…tRequestedFrameRate` from debug logs, and add detailed logging for Rutracker parsing failures;
…y it with a smaller size;
…ncrease max workers;
…avigation icons, add custom user agent, and implement URL fallback;
…sing and network requests;
…r and repository;
…code with windows-1251 charset for responses;
…for consistent response decoding across components;
…for decoding results, including checks for HTML structure and valid Cyrillic content;
…picViewModel tests;
… a new helper function, accompanied by a new test;
…her content paths;
…r last page pagination parsing;
…ic, including topics, pagination, seeders, and leechers;
…ction and simplify metadata cleanup regex;
… internal links, and enable navigation to linked topics;
…mic display, replacing explicit duration and bitrate UI;
…ents, and update link annotation handling;
…pand recognized metadata labels;
…adding a CoverLoader, updating RutrackerRepository to fetch and save covers, and modifying OfflineSearchDao to persist cover URLs and observe search results;
…ext extraction to use cleaned HTML, and introduce dedicated metadata extraction tests;
…lts by introducing `isValidForPagination` and applying it in `RutrackerRepository`;
…ailsPage` using `runBlocking` and `TopicDetails` models;
…st comments first and allowing previous pages to be loaded;
… pages and remove specific comment order assertions;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract player logic into separate manager classes for better maintainability and separation of concerns.