Repository navigation
docs: correct my own misdiagnosis — main was never broken (CDATA was innocent) - #2
Merged
Merged
Conversation
…innocent PR #1 recorded that ':app:mergeDebugResources has been failing on main since 3c3f210' because of the CDATA-wrapped version_and_updates strings. It was not: build_apk.yml completed successfully for 3c3f210 and again for the merge of PR #1, which published v1.0.137. The 'Can not extract resource from ParsedResource' errors named *three* resources and they were the three unescaped-apostrophe strings — aapt2 accepts both CDATA and \\uXXXX, so the CDATA edit I made is cosmetic (identical rendered text) and the '\u2026' → '…' change likewise only removed an escape that was already legal. - AUDIT §7 now states the correct sequence, including that I got it wrong, so the next reader does not inherit a phantom regression. - quality-gate.sh keeps the CDATA check but for the honest reason: inside CDATA, aapt's escape handling is off, so a \n or \' written there reaches the user literally — a real trap in a file whose other 660 strings depend on escapes. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1: correct a claim I made there.
PR #1 (and
docs/AUDIT-2026-10-14.md§7) recorded that:app:mergeDebugResourceshad been failing onmainsince3c3f210because of the<![CDATA[Version & updates]]>strings. That was wrong —build_apk.ymlcompleted successfully for3c3f210, and again for the merge of #1, which publishedv1.0.137.What actually happened: aapt2 reported
Can not extract resource from ParsedResourcefor three resources. I fixed the two CDATA strings, saw the count match the three apostrophe strings only in the next round, and never went back to re-check my first explanation. The three unextractable resources were the unescaped apostrophes; aapt2 accepts both CDATA and\uXXXX.quality-gate.shCDATA check stays, but for a reason that is actually true: inside CDATA, aapt's escape handling is off, so a\nor\'written there reaches the user literally. The cosmeticCDATA→&edit is left in place (identical rendered text, consistent with the other 660 strings).Docs + one comment; no code paths change. Not merged deliberately:
build_apk.ymlauto-publishes a GitHub release on every push tomain, so merging a docs-only fix alone would burn a version number (v1.0.138). Merge it with the next real change, or say the word and I will merge it on its own.