Repository navigation
OAuth redirect: gothwadstore:// -> kiwistore:// - #12
Merged
Merged
Conversation
- BuildConfig.OAUTH_REDIRECT_URI is now kiwistore://oauth/callback; the OAUTH_CLIENT_ID default stays kiwi-store. - AndroidManifest declares the new kiwistore VIEW filter and keeps the old gothwadstore filter only as a transition for logins started by old APKs. - AuthManager accepts only kiwistore (plus the documented legacy scheme), checks host/path, and keeps redirect_uri identical for authorize + token exchange. - UI/docs updated, and Robolectric tests pin the scheme, manifest filters and the token-exchange redirect_uri. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the Android OAuth redirect scheme from
gothwadstoretokiwistore.app/build.gradle.kts:OAUTH_REDIRECT_URI = "kiwistore://oauth/callback";OAUTH_CLIENT_IDdefault stayskiwi-store.AndroidManifest.xml: newkiwistoreVIEW/BROWSABLE filter; oldgothwadstorefilter kept only as a transition so sign-ins started by an older APK can still finish.AuthManager.kt: acceptskiwistore(plus the legacy scheme for the transition window), validates host +/callbackpath, and uses the sameredirect_urifor authorize and token exchange. Doc comments updated.AccountScreens.kt: the "Android returns to ..." string now showskiwistore://oauth/callback.AuthRedirectTest: pins the BuildConfig value, authorize URL, manifest filters, callback acceptance/rejection and the token-exchangeredirect_uri(MockWebServer).Verification
CI: unit tests + debug compile + lint (quality) and release APK/AAB build.
Follow-up
Accounts must register
kiwistore://oauth/callbackfor clientkiwi-store; keepgothwadstore://oauth/callbackregistered until the transition ends.