Repository navigation
fix(ui): bottom bar layout, Search/Profile tabs, sky-blue #0494F4 theme - #6
Merged
Merged
Conversation
…file, sky-blue #0494F4 theme Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
GothwadBottomBar's row usedheightIn(min = 80.dp)and every tab item usedfillMaxHeight(). Inside a Scaffold the row is measured with the full screen as its max height, so the bar grew to the entire screen: it sat over the header and the page content got zero height (<em>"kuch dikh hi nahi raha"</em>).TabShell.AccountScreenrendered a bareLazyColumn.What changed
height(72.dp)), tab items are vertically centred (icon 32dp + label), so the bar never expands and the Scaffold gives the content the remaining space.TabShell, same save/restore nav options as the other tabs, and it now renders insideGothwadScaffoldso the tab bar stays visible.AccountScreen) now usesGothwadScaffoldwith a "Profile" top bar (downloads + settings actions) and correct insets, so the bottom bar is visible there too.Settings.recentlyViewed, newest first, max 10) and recorded when an app detail opens.#0494F4(the launcher-icon blue): primary + containers in light/dark, banner gradient#0494F4 → #00C6FF, icon palette, launcher/splash accent (gothwad_accent). Brand-named palette entries (Brand/BrandDark/BrandLight/BrandContainer/BrandInk) replace the oldGreen*names so green cannot creep back in. Selected chips, segmented controls, install-progress rings and the info banner now use the brand container; semantic success/installed badges stay green.Verification
No Java/Android SDK in the authoring sandbox — CI (quality gate) compiles, runs unit tests and lint on this PR.