Repository navigation
馃悰 fix(tile, radio): correction de la propri茅t茅 storybook pictogramName - #1520
Merged
Merged
Conversation
keryanS
commented
Sep 4, 2026
keryanS
commented
Contributor
- Passage de la propri茅t茅 pictogramName d'une string 脿 un select listant tous les pictogrammes
keryanS
added
correctif
There was a problem hiding this comment.
馃煝 Approval recommended
Les changements r茅pondent au besoin d茅crit et ne pr茅sentent pas de risque fonctionnel majeur, les retours restants 茅tant des am茅liorations mineures de robustesse/qualit茅.
Pull request overview
Cette PR am茅liore la configuration Storybook des composants Tile et Radio en rempla莽ant la saisie libre du pictogramName par une liste de s茅lection bas茅e sur la liste des pictogrammes, et rend le rendu EJS du pictogramme plus tol茅rant (cat茅gorie fournie ou pictogramme introuvable).
Changes:
- Passage de
pictogramNameen select avec options issues depictogram.jsondans Storybook (Tile, Radio). - Ajustement du template EJS
pictogram.ejspour 茅viter un crash si le pictogramme n鈥檈st pas trouv茅 et permettre de fournirpictogram.category.
File summaries
| File | Description |
|---|---|
| src/dsfr/core/template/ejs/artwork/pictogram.ejs | Rend le calcul de cat茅gorie plus robuste et conditionne le rendu du <svg>. |
| src/dsfr/component/tile/template/stories/tile-arg-types.js | Remplace le contr么le texte par un select bas茅 sur la liste des pictogrammes. |
| src/dsfr/component/radio/template/stories/radio-arg-types.js | Remplace le contr么le texte par un select bas茅 sur la liste des pictogrammes. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 3
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
zellerbaptiste
approved these changes
Sep 7, 2026
zellerbaptiste
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.