Repository navigation
Conversation
keryanS
commented
Sep 24, 2026
keryanS
commented
Contributor
- corrige l'issue Emitter.remove supprime tous les Ă©couteurs suivants (splice sans deleteCount)Â #1531
There was a problem hiding this comment.
Copilot review overview
đą Approval recommended
Le changement est minimal, ciblé et corrige directement la cause racine (utilisation incorrecte de splice) sans impact fonctionnel négatif attendu.
Review effort: Lite
Findings: None
What changed in this PR
Corrige un bug dans lâutilitaire Emitter du cĆur DSFR oĂč remove(type, closure) supprimait involontairement tous les Ă©couteurs enregistrĂ©s aprĂšs celui retirĂ©, Ă cause dâun splice(index) sans deleteCount.
Changes:
- Remplace
splice(index)parsplice(index, 1)pour ne retirer quâun seul Ă©couteur, conformĂ©ment au comportement attendu dĂ©crit dans lâissue #1531.
| File | Description |
|---|---|
| src/âdsfr/âcore/âscript/âapi/âutilities/âemitter.js | Corrige la suppression dâun listener pour Ă©viter de retirer tous les suivants. |
đĄ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.