Repository navigation
Renamed GOSoundResample's SampleVector family to FrameVector, and its SampleT/ResT template parameters to SrcItemT/ResItemT, for consistency with GOSoundBuffer's Frame/Item vocabulary - #2647
Merged
oleg68 merged 1 commit intoOct 8, 2026
Conversation
Contributor
Author
|
@codex review |
… SampleT/ResT template parameters to SrcItemT/ResItemT, for consistency with GOSoundBuffer's Frame/Item vocabulary FloatingSampleVector/PtrSampleVector/BoundedPtrSampleVector become FloatingFrameVector/PtrFrameVector/BoundedPtrFrameVector, NextSample() becomes NextItem(), and the SampleVectorT/sV template parameter and variable become FrameVectorT/fV. This is a pure rename with no behaviour change, preparing GOSoundResample's vocabulary to match GOSoundBuffer's own Frame/Item terminology ahead of an upcoming per-frame variable-rate resampling path (GrandOrgue#709). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
oleg68
force-pushed
the
rename/sample-vector-to-frame-vector
branch
from
October 7, 2026 09:18
0d6494f to
ac4d739
Compare
Contributor
Author
|
Could you approve this PR as soon as possible? It is quite simple: only renaming of GOSoundResampler members without any code changing. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2647 +/- ##
===========================================
+ Coverage 31.96% 46.87% +14.91%
===========================================
Files 524 463 -61
Lines 27082 22129 -4953
===========================================
+ Hits 8657 10374 +1717
+ Misses 18425 11755 -6670 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rousseldenis
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FloatingSampleVector/PtrSampleVector/BoundedPtrSampleVector become
FloatingFrameVector/PtrFrameVector/BoundedPtrFrameVector, NextSample()
becomes NextItem(), and the SampleVectorT/sV template parameter and
variable become FrameVectorT/fV. This is a pure rename with no
behaviour change, preparing GOSoundResample's vocabulary to match
GOSoundBuffer's own Frame/Item terminology ahead of an upcoming
per-frame variable-rate resampling path (#709).
🤖 Generated with Claude Code