This repository was archived by the owner on Nov 18, 2020. It is now read-only.
Add Seafile Storage whitelist in Seedvault. - #2
Open
cyrinux wants to merge 1 commit into
Open
Conversation
Hi, Here is a tiny PR to add the capability to backup on self hosted storage app seafile (seadroid). I add com.seafile.seadroid2 in whitelisted app, next to nextcloud. According to those links, this should work: https://github.com/haiwen/seadroid/blob/a9d7c2a2b11aa39150acfcdd421a9e612cb936f7/app/src/main/java/com/seafile/seadroid2/provider/SeafileProvider.java#L116 where in nextcloud in the same function: https://github.com/nextcloud/android/blob/c57448e32c4d1ff41c00bc99a63665f3ca546e7a/src/main/java/com/owncloud/android/providers/DocumentsStorageProvider.java#L138 they use https://github.com/nextcloud/android/blob/c57448e32c4d1ff41c00bc99a63665f3ca546e7a/src/main/res/values/setup.xml#L13 Thanks !
|
Have you tested that this actually works? |
Author
|
No, unfortunately I'm unable to test as my pixel 3a is my only device and I can't wipe it to install a self-signed image. |
Author
|
Hi guys, how can I help you with this? Any chance that this get merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Here is a tiny PR to add the capability to backup on self hosted storage app seafile (seadroid).
I opened an issue long time ago here https://github.com/stevesoltys/seedvault/issues/84#issuecomment-676609325 .
And I understand that finally I need to make a PR here.
I add com.seafile.seadroid2 in whitelisted app, next to nextcloud.
According to those links, this should work:
https://github.com/haiwen/seadroid/blob/a9d7c2a2b11aa39150acfcdd421a9e612cb936f7/app/src/main/java/com/seafile/seadroid2/provider/SeafileProvider.java#L116
where in nextcloud in the same function:
https://github.com/nextcloud/android/blob/c57448e32c4d1ff41c00bc99a63665f3ca546e7a/src/main/java/com/owncloud/android/providers/DocumentsStorageProvider.java#L138
they use
https://github.com/nextcloud/android/blob/c57448e32c4d1ff41c00bc99a63665f3ca546e7a/src/main/res/values/setup.xml#L13
Thanks !