Skip to content

Fix deltas error #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smellsblue merged 2 commits into from
Jul 10, 2025
Merged

Fix deltas error #930

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0045a8f
Attempt to fix error in reconciliations
smellsblue Jul 10, 2025
9de5195
Only unscope the items if the reconciliation is complete
smellsblue Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/models/reconciliation_deltas.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@ class ReconciliationDeltas

def initialize(reconciliation, items = nil)
@reconciliation = reconciliation
@items = items || Item.includes(:category).with_requested_quantity.to_a
item_scope =
if reconciliation.complete?
Item.unscoped
else
Item
end
@items = items || item_scope.includes(:category).with_requested_quantity.to_a
end

def each(&block)
Expand Down