Skip to content

Add all remaining modern spellbook spells #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GregHib merged 28 commits into from
Mar 12, 2026

Remove duplicate code

73bb30c
Select commit
Loading
Failed to load commit list.
Merged

Add all remaining modern spellbook spells #915

Remove duplicate code
73bb30c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 12, 2026 in 0s

38.58% (+0.35%) compared to 3066dc4

View this Pull Request on Codecov

38.58% (+0.35%) compared to 3066dc4

Details

Codecov Report

❌ Patch coverage is 66.26984% with 170 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.58%. Comparing base (3066dc4) to head (73bb30c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...content/skill/magic/book/modern/TelekineticGrab.kt 61.90% 7 Missing and 9 partials ⚠️
...in/content/entity/player/inv/item/take/ItemTake.kt 44.00% 8 Missing and 6 partials ⚠️
...ent/skill/magic/book/modern/EnchantCrossbowBolt.kt 78.12% 8 Missing and 6 partials ⚠️
...n/content/skill/magic/book/modern/TeleportOther.kt 80.00% 4 Missing and 5 partials ⚠️
.../kotlin/content/skill/magic/book/modern/Alchemy.kt 77.77% 2 Missing and 6 partials ⚠️
...ontent/skill/magic/book/modern/EnchantJewellery.kt 84.78% 4 Missing and 3 partials ⚠️
...lin/content/skill/magic/book/modern/OrbCharging.kt 78.12% 3 Missing and 4 partials ⚠️
...lin/content/skill/magic/jewellery/GamesNecklace.kt 61.11% 4 Missing and 3 partials ⚠️
...s/engine/client/instruction/InstructionHandlers.kt 0.00% 5 Missing ⚠️
...s/voidps/engine/data/definition/EnumDefinitions.kt 0.00% 4 Missing ⚠️
... and 40 more
Additional details and impacted files
Files with missing lines Coverage Δ
...in/kotlin/content/area/kandarin/ardougne/Edmond.kt 57.59% <100.00%> (ø)
...in/content/area/misthalin/lumbridge/castle/Cook.kt 37.95% <100.00%> (ø)
...otlin/content/entity/player/equip/WornEquipment.kt 48.14% <100.00%> (+7.40%) ⬆️
...ntent/minigame/sorceress_garden/SorceressGarden.kt 42.42% <100.00%> (ø)
...e/src/main/kotlin/content/skill/fishing/Fishing.kt 48.35% <100.00%> (ø)
...e/src/main/kotlin/content/skill/fletching/Bolts.kt 65.21% <100.00%> (ø)
...e/src/main/kotlin/content/skill/fletching/Darts.kt 65.21% <100.00%> (ø)
...kotlin/content/skill/fletching/FletchUnfinished.kt 71.79% <100.00%> (ø)
...n/kotlin/content/skill/fletching/HeadlessArrows.kt 62.16% <100.00%> (+30.91%) ⬆️
...kotlin/content/skill/magic/book/lunar/CurePlant.kt 56.52% <100.00%> (ø)
... and 54 more

... and 4 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #915      +/-   ##
============================================
+ Coverage     38.23%   38.58%   +0.35%     
- Complexity     7680     7777      +97     
============================================
  Files          1555     1563       +8     
  Lines         62523    62852     +329     
  Branches      15674    15733      +59     
============================================
+ Hits          23906    24252     +346     
+ Misses        33305    33186     -119     
- Partials       5312     5414     +102
Components Coverage Δ
Content 36.84% <67.72%> (+0.56%) ⬆️
Engine 45.92% <45.45%> (-0.03%) ⬇️
Network 60.85% <ø> (-0.04%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov