Skip to content

Add ancient cavern and kuradals dungeon#924

Merged
GregHib merged 24 commits intomainfrom
ancient-cavern
Mar 21, 2026
Merged

Add ancient cavern and kuradals dungeon#924
GregHib merged 24 commits intomainfrom
ancient-cavern

Conversation

@GregHib
Copy link
Copy Markdown
Owner

@GregHib GregHib commented Mar 21, 2026

#503

  • Add waterfiends
  • Add mithril dragons
  • Add green brutal dragons
  • Add barbarian spirits
  • Add kuradals dungeon entrance and barriers
  • Add ferocious ring
  • Add skeleton grave looting
  • Fix metal dragon animations
  • Fix npc combat projectile offsets
  • Fix spellbook filters closes Fix spellbook filtering #923

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 21, 2026

Qodana for JVM

3 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 3

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@GregHib GregHib merged commit e2a097d into main Mar 21, 2026
3 checks passed
@GregHib GregHib deleted the ancient-cavern branch March 21, 2026 13:33
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 21, 2026

Codecov Report

❌ Patch coverage is 9.33333% with 136 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.34%. Comparing base (6eec11c) to head (6dfa1be).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...in/baxtorian_falls/ancient_cavern/AncientCavern.kt 6.00% 47 Missing ⚠️
.../baxtorian_falls/ancient_cavern/KuradalsDungeon.kt 6.97% 40 Missing ⚠️
...main/kotlin/content/entity/proj/ShootProjectile.kt 0.00% 24 Missing ⚠️
...in/baxtorian_falls/ancient_cavern/FerociousRing.kt 36.36% 13 Missing and 1 partial ⚠️
...me/src/main/kotlin/content/entity/combat/Target.kt 0.00% 4 Missing and 2 partials ⚠️
...voidps/engine/data/definition/CombatDefinitions.kt 0.00% 2 Missing ⚠️
...rc/main/kotlin/content/entity/npc/combat/Attack.kt 0.00% 0 Missing and 1 partial ⚠️
...kotlin/content/skill/magic/book/SpellBookFilter.kt 0.00% 1 Missing ⚠️
...main/kotlin/world/gregs/voidps/type/area/Cuboid.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...rc/main/kotlin/content/entity/npc/combat/Attack.kt 51.74% <0.00%> (+1.40%) ⬆️
...kotlin/content/skill/magic/book/SpellBookFilter.kt 32.14% <0.00%> (ø)
...main/kotlin/world/gregs/voidps/type/area/Cuboid.kt 67.30% <0.00%> (ø)
...voidps/engine/data/definition/CombatDefinitions.kt 0.00% <0.00%> (ø)
...me/src/main/kotlin/content/entity/combat/Target.kt 33.65% <0.00%> (-2.07%) ⬇️
...in/baxtorian_falls/ancient_cavern/FerociousRing.kt 36.36% <36.36%> (ø)
...main/kotlin/content/entity/proj/ShootProjectile.kt 61.87% <0.00%> (-10.92%) ⬇️
.../baxtorian_falls/ancient_cavern/KuradalsDungeon.kt 6.97% <6.97%> (ø)
...in/baxtorian_falls/ancient_cavern/AncientCavern.kt 6.00% <6.00%> (ø)

... and 1 file with indirect coverage changes

@@             Coverage Diff              @@
##               main     #924      +/-   ##
============================================
- Coverage     38.41%   38.34%   -0.07%     
- Complexity     7810     7814       +4     
============================================
  Files          1581     1584       +3     
  Lines         63423    63566     +143     
  Branches      15844    15885      +41     
============================================
+ Hits          24361    24373      +12     
- Misses        33633    33760     +127     
- Partials       5429     5433       +4     
Components Coverage Δ
Content 36.51% <9.52%> (-0.10%) ⬇️
Engine 45.83% <0.00%> (-0.01%) ⬇️
Network 60.85% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix spellbook filtering

1 participant