fix: allow terminal ioctls under Landlock#92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LANDLOCK_ACCESS_FS_IOCTL_DEVin Landlock write permissions for ABI v5+/dev/ttyand/dev/pts/*into raw modeMotivation
Interactive Node.js TUIs can fail under Greywall with
setRawMode EACCESwhen Landlock handlesIOCTL_DEVbut the device path rule does not grant it. This was reproduced with the pi coding agent interactive mode; non-interactive commands worked, whilepifailed entering raw mode.This fix should start allowing OpenClaw-style interactive coding agent users to run safely inside Greywall instead of being limited to non-interactive commands.
Testing
go test ./internal/sandboxgreywall -- pi --offlineworks interactively