feat: add signing component registry and firmware-gated reqs#728
Merged
yilmazbahadir merged 6 commits intodevfrom Mar 4, 2026
Merged
feat: add signing component registry and firmware-gated reqs#728yilmazbahadir merged 6 commits intodevfrom
yilmazbahadir merged 6 commits intodevfrom
Conversation
…ents Migrate EVM/Solana/Cosmos/XRP lattice signers to resolve primitives via registry, add transactional chain registration, and extend unit test coverage.
70f9fae to
a83c402
Compare
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d308cf86e2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…imitives on unregister Add lattice signer fallback to EXTERNAL.SIGNING when resolvePrimitive is absent, and remove plugin-owned primitive definitions during unregisterChain to prevent stale conflicts.
netbonus
reviewed
Mar 2, 2026
Replace Primitive* types and registry APIs with SigningComponent* across chain-core and sdk. Migrate lattice signers/context to resolveSigningComponent with EXTERNAL.SIGNING fallback to preserve DeviceContext compatibility. Rename primitive-focused modules/tests and keep transactional plugin register/unregister cleanup for plugin-owned signing components.
netbonus
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR introduces a plugin-owned signing-component registry for chain plugins and removes broad SDK helper coupling when adding/migrating chains.
It includes:
minFirmwaregatingevm,solana,cosmos,xrpDeviceContextintegrations🔧 Context / Implementation
SigningComponentKind,SigningComponentDefinition,SigningComponentRequirementChainSigningSuitesigningSuite?: ChainSigningSuiteonChainPlugincreateSigningComponentRegistry,preflight, atomicregister,resolve,resolveOrThrow,reverseResolve,has,list,resetEXTERNAL.SIGNING.{HASHES,CURVES,ENCODINGS}minFirmwarerequired)unregisterChain()removes owned definitions and prevents stale conflicts on re-registeruseChain()before signer creation.context.resolveSigningComponent(...):evm,solana,cosmos,xrpconstants.EXTERNAL.SIGNINGwhen resolver is absent>= 0.18.0).packages/types/src/firmware.ts) by removing permissive index signatures from signing maps.GET_ADDR_FLAGSandgetFwVersionConst()behavior remain unchanged in this PR.Concrete developer experience — what a new chain plugin author writes: