Skip to content

reset data to connect #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
netbonus merged 1 commit into from
Sep 22, 2025
Merged

reset data to connect #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/components/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@ class Main extends React.Component<any, MainState> {
return;
}

// CRITICAL: Do not return data if the connection failed
if (this.state.keyringConnectionFailed) {
console.error(`[KEYRING_RETURN] 🚫 BLOCKED: Connection failed - refusing to return data to consuming library`);
console.error(`[KEYRING_RETURN] This prevents consuming library from receiving invalid/stale connection data`);
Expand Down Expand Up @@ -409,6 +408,12 @@ class Main extends React.Component<any, MainState> {
showLoading
});

// Reset failure flag at the start of any new connection attempt
if (this.state.openedByKeyring && this.state.keyringConnectionFailed) {
console.log(`[KEYRING_CONNECTION] Resetting keyringConnectionFailed flag for fresh attempt`);
this.setState({ keyringConnectionFailed: false });
}

// Sanity check -- this should never get hit
if (!deviceID || !password) {
console.error(`[KEYRING_CONNECTION] Missing credentials - deviceID: ${!!deviceID}, password: ${!!password}`);
Expand Down