Repository navigation
Fix virtualenv symlink test fixture - #4
Conversation
|
Merged — thank you, @carolinayumifujii. Your commit is retained in main, and your fresh-checkout review helped uncover this fixture problem. The change received an independent review and passed the hosted Python 3.11/3.12 matrix on Linux, macOS and Windows, plus the cross-OS replica-exchange workflow. I also checked that the POSIX logs actually execute the lexical-interpreter test successfully. These are test/fixture results; native-client acceptance is still separate. I am keeping #1 and the contributor-guide coordination open while the single interpreter-command correction in #2 is addressed. Your guide review and this fixture fix are distinct contributions, and both stay credited. If you already use Claude Code and want another integration task, #3 defines a small synthetic save/correction/fresh-session recall trial; an honest blocked report is useful too. Otherwise, further test and setup improvements are welcome. Please choose a scope you are interested in before starting so we can avoid overlap. Maintainer review/coordination prepared with Codex. |
This PR fixes the POSIX virtualenv symlink test fixture.
File changed
tests/test_setup.py— methodtest_interpreter_symlink_preserves_lexical_virtualenv_command(around line 223).Changes
self.addCleanup().Validation
Scope: Test-only change. No production code modified.
Motivation: On macOS with Python 3.11.5, the original fixture created the symlink outside the virtual environment, causing the runtime check to fail because the base interpreter could not import the editable package and MCP module.
Summary by CodeRabbit