Fix for #749: Added a nil sanity check to _G.hspairs before the call to pairs - #750
Open
DeviousNess95 wants to merge 1 commit into
Open
Fix for #749: Added a nil sanity check to _G.hspairs before the call to pairs#750DeviousNess95 wants to merge 1 commit into
DeviousNess95 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made this change to fix #749, but wanted to submit it. It seems that _g_patches.script is sort of a core script, and many others rely upon it. If a similar condition would exist elsewhere, it may help with that, as well. I also note that it may be an incomplete fix, but I can't really tell on my own. Lua is not my strong suit. However, it's a one-liner, and so far works beautifully. I disassembled 60 PBs very quickly with no issues and no drop in performance. I can't foresee any negative effects of adding this quick sanity check to make sure we're not gonna crash.