Skip to content

feedback on 110 #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaredatron wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feedback on 110 #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions _goals/110-Functional_Programming-Concepts_and_Exercises.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,25 @@ The article [The Two Pillars of JavaScript — Pt 2: Functional Programming]

## Specifications

__FEEDBACK:__ there is no way to confirm someone has read something :P

- [ ] Read the [Mostly Adequate Guide to Functional Programming][mostly-adequate-guide] through Chapter 8: Tupperware

__FEEDBACK:__ can we specify where so whoever grades this artifact knows where to look? Maybe we can change these specs to be one checkbox per spec you're written. And we can just run the tests to determine completeness?

- [ ] Exercises from the Mostly Adequate Guide are completed and included in the artifact repo
- [ ] [Chapter 4 Exercises](https://drboolean.gitbooks.io/mostly-adequate-guide/content/ch4.html#exercises) completed and all tests are passing
- [ ] [Chapter 5 Exercises](https://drboolean.gitbooks.io/mostly-adequate-guide/content/ch5.html#exercises) completed and all tests are passing
- [ ] [Chapter 8 Exercises](https://drboolean.gitbooks.io/mostly-adequate-guide/content/ch8.html#exercises) completed and all tests are passing
- [ ] [5 Functional Programming katas][codewars-chals] from CodeWars are completed and added to the `code-wars` folder of your artifact repo
- [ ] Code uses a linter and there are no linting errors.

__FEEDBACK:__ this spec seems redundant if you're using a properly configured linter

- [ ] Code is well formatted with proper spacing and indentation.

__FEEDBACK:__ this is too subject. We should remove it or replace it in all the goals its listed on.

- [ ] Variables, functions, files, etc. have appropriate and meaningful names.
- [ ] All major features are added via pull requests with a clear description and concise commit messages.
- [ ] The artifact produced is properly licensed, preferably with the [MIT license][mit-license].
Expand Down