Skip to content

implement new SMODS features#82

Open
vitellaryjr wants to merge 7 commits into
GuilloryCraft:mainfrom
vitellaryjr:smods-features
Open

implement new SMODS features#82
vitellaryjr wants to merge 7 commits into
GuilloryCraft:mainfrom
vitellaryjr:smods-features

Conversation

@vitellaryjr
Copy link
Copy Markdown

  • add attributes to every joker
  • use SMODS.scale_card for Rubber Ducky, Pocket Aces, Purple Joker, Compost, Turtle, Handbook, Espresso, Traffic Light, Hold Your Breath, Toby the Corgi, Ship of Theseus, Hoarder, Chain Lightning, and Joka Lisa
  • implement SMODS probability functions for Starfruit, Warlock, and Bad Apple
  • use SMODS.has_enhancement for Double Rainbow, Warlock, and Prideful Joker
  • use SMODS.destroy_card for Starfruit, Compost, Candy Necklace, Espresso, Hold Your Breath, Toby the Corgi, Ambrosia, and Bad Apple (disclaimer: Bad Apple's destruction colour will be incorrect until this SMODS PR is merged, but it still works fine until then)
  • use SMODS.add_card for Warlock, Clown College, Ambrosia, and Yin-Yang
  • use level_up context return for Starfruit, and SMODS.upgrade_poker_hands for Accretion Disk
  • use dollars context return for Yellow Card
  • use context.debuff_card for Permanent Marker (and remove patch)
  • use context.initial_scoring_step for Clown Car (and remove patch)
  • use context.money_altered for Hoarder (and remove hook)
  • remove retrigger value from Double Rainbow, Tuxedo, and Joker of the Year (to prevent it from getting scaled when it's not shown; i know this is how vanilla jokers like Mime work but for the sake of cross-mod compatibility it's better not to)
  • use more config values for Compost, Monte Haul, Traffic Light, and Accretion Disk
  • remove unnecessary card area checks for the retrigger effects of Double Rainbow, Tuxedo, and the Echo Deck
  • remove unnecessary cardarea == G.jokers checks for most joker evaluations
  • use context.main_eval in place of not context.repetition and not context.individual for end of round effects
  • simplify scoring context effects for all scoring jokers
  • use message context return in place of a lot of instances of card_eval_status_text
  • remove Rubber Ducky patch for negative chips bonus (it's handled by SMODS already now)
  • queue events differently for Ship of Theseus so you don't see cards get made before they break
  • remove unnecessary context.cards_destroyed check in Ship of Theseus, and simplify its code a bit
  • rewrite Traffic Light and Bobby to support value changes, and also use its own variables more accurately
  • fix Pocket Aces giving a 0 dollar cashout message
  • correctly mark Accretion Disk as not blueprint compatible
  • fix crash with Archeology Deck

- implemented SMODS probability functions for Starfruit, Warlock, and Bad Apple
- implemented SMODS.destroy_cards in place of all previous joker destruction effects
- remove unnecessary `context.cardarea` checks where applicable (mostly related to instances where `context.joker_main` covers it)
- use `context.main_eval` during `context.end_of_round` where appropriate
- remove patch for Permanent Marker, use `context.debuff_card` instead
- remove patch for Clown Car, use `context.initial_scoring_step` instead (which also just supports what it's doing anyway)
- queue events differently for Ship of Theseus so you don't see cards get made before they break
- rewrite Bobby to support value changes, and also use its own variables more accurately
- remove unnecessary Rubber Duck patch (already handled by smods now)
- fix Pocket Aces giving a 0 dollar cashout message
- correctly mark Accretion Disk as not blueprint compatible
- a lot of other various simplification, sorry i didn't quite keep track of everything
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant