implement new SMODS features#82
Open
vitellaryjr wants to merge 7 commits into
Open
Conversation
- implemented SMODS probability functions for Starfruit, Warlock, and Bad Apple - implemented SMODS.destroy_cards in place of all previous joker destruction effects - remove unnecessary `context.cardarea` checks where applicable (mostly related to instances where `context.joker_main` covers it) - use `context.main_eval` during `context.end_of_round` where appropriate - remove patch for Permanent Marker, use `context.debuff_card` instead - remove patch for Clown Car, use `context.initial_scoring_step` instead (which also just supports what it's doing anyway) - queue events differently for Ship of Theseus so you don't see cards get made before they break - rewrite Bobby to support value changes, and also use its own variables more accurately - remove unnecessary Rubber Duck patch (already handled by smods now) - fix Pocket Aces giving a 0 dollar cashout message - correctly mark Accretion Disk as not blueprint compatible - a lot of other various simplification, sorry i didn't quite keep track of everything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SMODS.scale_cardfor Rubber Ducky, Pocket Aces, Purple Joker, Compost, Turtle, Handbook, Espresso, Traffic Light, Hold Your Breath, Toby the Corgi, Ship of Theseus, Hoarder, Chain Lightning, and Joka LisaSMODS.has_enhancementfor Double Rainbow, Warlock, and Prideful JokerSMODS.destroy_cardfor Starfruit, Compost, Candy Necklace, Espresso, Hold Your Breath, Toby the Corgi, Ambrosia, and Bad Apple (disclaimer: Bad Apple's destruction colour will be incorrect until this SMODS PR is merged, but it still works fine until then)SMODS.add_cardfor Warlock, Clown College, Ambrosia, and Yin-Yanglevel_upcontext return for Starfruit, andSMODS.upgrade_poker_handsfor Accretion Diskdollarscontext return for Yellow Cardcontext.debuff_cardfor Permanent Marker (and remove patch)context.initial_scoring_stepfor Clown Car (and remove patch)context.money_alteredfor Hoarder (and remove hook)retriggervalue from Double Rainbow, Tuxedo, and Joker of the Year (to prevent it from getting scaled when it's not shown; i know this is how vanilla jokers like Mime work but for the sake of cross-mod compatibility it's better not to)cardarea == G.jokerschecks for most joker evaluationscontext.main_evalin place ofnot context.repetition and not context.individualfor end of round effectsmessagecontext return in place of a lot of instances ofcard_eval_status_textcontext.cards_destroyedcheck in Ship of Theseus, and simplify its code a bit