v0.50.0-pre-release

.github/workflows/airdodge_faf_reminder.yml

@@ -0,0 +1,47 @@
+name: Reminder to update airdodge FAF when fallspeed params are edited
+
+on:
+  pull_request:
+    branches:
+      - pre-release
+    types: [opened, reopened, synchronize]
+
+jobs:
+  scan-diff:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Search for air_accel_y/air_speed_y_stable param edits
+        id: param_change_search
+        run: |
+          FILE_PATH="romfs/source/fighter/common/param/fighter_param.prcxml"
+
+          BEFORE=${{ github.event.before }}
+          AFTER=${{ github.event.after }}
+
+          # If 'before' is all zeros (initial push), compare against the parent of HEAD
+          if [ "${{ github.event.action }}" == "opened" ] || [ "${{ github.event.action }}" == "reopened" ]; then
+            BEFORE="HEAD^"
+          fi
+
+          if git diff --unified=0 $BEFORE $AFTER -- "$FILE_PATH" | grep -qE "(air_accel_y|air_speed_y_stable)"; then
+            echo "found=true" >> $GITHUB_OUTPUT
+          else
+            echo "found=false" >> $GITHUB_OUTPUT
+          fi
+
+      - name: Post Comment
+        if: steps.param_change_search.outputs.found == 'true'
+        uses: peter-evans/create-or-update-comment@v4
+        with:
+          issue-number: ${{ github.event.pull_request.number }}
+          body: |
+            I see you have edited either the `air_accel_y` or `air_speed_y_stable` params for a character. Did you remember to update their airdodge FAF params accordingly? :)
+
+            You can use the airdodge FAF calculator here: https://www.desmos.com/calculator/8rgzdgk19v
+
+            Airdodge FAF params (`escape_air_cancel_frame` and `escape_air_slide_cancel_frame`) are found in *fighter_param_motion.prcxml*.

.github/workflows/build_devrelease.yml

@@ -1,41 +1,26 @@
 name: build_devrelease
 on:
   workflow_dispatch:
+    inputs:
+      romfs-ref:
+        description: 'Git ref for the hdr-private romfs clone (branch, tag, or sha)'
+        required: false
+        default: 'dev'
+        type: string
+      bundle-stages:
+        description: 'Include hdr-stages in romfs.zip'
+        required: false
+        default: false
+        type: boolean
 
 jobs:
-  version_check:
-    runs-on: ubuntu-24.04
-    env:
-      GITHUB_TOKEN: ${{ secrets.RELEASE_TOKEN }}
-    steps:
-      - id: latest_package
-        continue-on-error: true
-        uses: pozetroninc/github-action-get-latest-release@master
-        with:
-          repository: HDR-Development/HDR-DevReleases
-          token: ${{ secrets.RELEASE_TOKEN }}
-
-      # fail out if there's already a release for this commit
-      - name: ensure one build per sha
-        if: ${{ contains(steps.latest_package.outputs.description, github.sha) }}
-        run: exit 1
-
   plugin_build:
     env:
       PLUGIN_NAME: hdr
     runs-on: ubuntu-24.04
-    needs: version_check
-    container: 
+    container:
       image: wuboyth/skyline-plugin-builder:latest
     steps:
-    # - name: Free Disk Space (Ubuntu)
-    #   uses: jlumbroso/free-disk-space@v1.3.1
-
-    # - name: setup python
-    #   uses: actions/setup-python@v5.1.0
-    #   with:
-    #     python-version: '3.9' # Version range or exact version of a Python version to use, using SemVer's version range syntax
-
     - name: checkout version
       uses: actions/checkout@v4.1.4
 
@@ -53,87 +38,87 @@ jobs:
         current_version: ${{ steps.package_latest.outputs.release }}
         level: patch
 
+    - name: clone romfs
+      id: clone_romfs
+      run: |
+        apt-get update && apt-get install -y zip
+        git clone --branch ${{ github.event.inputs.romfs-ref }} --depth 1 \
+          https://x-access-token:${{ secrets.RELEASE_TOKEN }}@github.com/HDR-Development/hdr-private.git hdr-private
+        cd hdr-private/romfs
+        if [ "${{ github.event.inputs.bundle-stages }}" = "true" ]; then
+          zip -r ../../romfs.zip hdr-assets hdr-stages
+        else
+          zip -r ../../romfs.zip hdr-assets
+        fi
+      env:
+        GITHUB_TOKEN: ${{ secrets.RELEASE_TOKEN }}
+
     # build the project
     - run: |
-        cd scripts && NO_RUST_NIGHTLY=1 python3 make_dist.py build version=${{ steps.bump-semver.outputs.new_version }}-private name=hdr-private && cd ..
+        cd scripts && NO_RUST_NIGHTLY=1 python3 make_dist.py build version=${{ steps.bump-semver.outputs.new_version }}-private name=hdr && cd ..
         du -sh *
         rm -rf target
         du -sh *
       env:
         HOME: /root
 
-    - id: romfs_version
-      uses: pozetroninc/github-action-get-latest-release@master
-      with:
-        token: ${{ secrets.RELEASE_TOKEN }}
-        repository: HDR-Development/romfs-release
-
-    - name: Download romfs
-      id: get_romfs
-      uses: dsaltares/fetch-gh-release-asset@master
-      with:
-        repo: 'HDR-Development/romfs-release'
-        version: 'tags/${{ steps.romfs_version.outputs.release }}'
-        file: 'romfs.zip'
-        token: ${{ secrets.RELEASE_TOKEN }}
-
     - name: make package
       run: |
         python3 scripts/full_package.py devrelease none
 
-    - name: Download latest switch package
-      id: get_old_switch_package
-      if: steps.package_latest.outcome != 'failure'
-      uses: dsaltares/fetch-gh-release-asset@master
-      with:
-        repo: 'HDR-Development/HDR-DevReleases'
-        version: 'tags/${{ steps.package_latest.outputs.release }}'
-        file: 'switch-package.zip'
-        token: ${{ secrets.RELEASE_TOKEN }}
+    # - name: Download latest switch package
+    #   id: get_old_switch_package
+    #   if: steps.package_latest.outcome != 'failure'
+    #   uses: dsaltares/fetch-gh-release-asset@master
+    #   with:
+    #     repo: 'HDR-Development/HDR-DevReleases'
+    #     version: 'tags/${{ steps.package_latest.outputs.release }}'
+    #     file: 'switch-package.zip'
+    #     token: ${{ secrets.RELEASE_TOKEN }}
 
     # build the upgrade.zip and deletions.json
-    - name: make upgrade artifacts
-      if: steps.package_latest.outcome != 'failure'
-      run: |
-        python3 scripts/make_diff.py devrelease
+    # - name: make upgrade artifacts
+    #   if: steps.package_latest.outcome != 'failure'
+    #   run: |
+    #     python3 scripts/make_diff.py devrelease
 
-    - name: show upgrade artifacts
-      if: steps.package_latest.outcome != 'failure'
-      run: |
-        ls && stat * && echo && ls upgrade_artifacts && stat upgrade_artifacts/*
+    # - name: show upgrade artifacts
+    #   if: steps.package_latest.outcome != 'failure'
+    #   run: |
+    #     ls && stat * && echo && ls upgrade_artifacts && stat upgrade_artifacts/*
 
     # upload the upgrade data to the previous release for auto updater
-    - name: Upload upgrade data to previous release
-      if: steps.package_latest.outcome != 'failure'
-      uses: svenstaro/upload-release-action@v2
-      with:
-        repo_token: ${{ secrets.RELEASE_TOKEN }}
-        file: upgrade_artifacts/upgrade.zip
-        prerelease: true
-        make_latest: false
-        file_glob: true
-        asset_name: upgrade
-        repo_name: HDR-Development/HDR-DevReleases
-        tag: ${{ steps.package_latest.outputs.release }}
-        overwrite: true
+    # - name: Upload upgrade data to previous release
+    #   if: steps.package_latest.outcome != 'failure'
+    #   uses: svenstaro/upload-release-action@v2
+    #   with:
+    #     repo_token: ${{ secrets.RELEASE_TOKEN }}
+    #     file: upgrade_artifacts/upgrade.zip
+    #     prerelease: true
+    #     make_latest: false
+    #     file_glob: true
+    #     asset_name: upgrade
+    #     repo_name: HDR-Development/HDR-DevReleases
+    #     tag: ${{ steps.package_latest.outputs.release }}
+    #     overwrite: true
 
     # upload the upgrade deletions to the previous release for auto updater
-    - name: Upload upgrade deletions to previous release
-      if: steps.package_latest.outcome != 'failure'
-      uses: svenstaro/upload-release-action@v2
-      with:
-        repo_token: ${{ secrets.RELEASE_TOKEN }}
-        file: upgrade_artifacts/deletions.json
-        prerelease: true
-        make_latest: false
-        file_glob: true
-        asset_name: deletions
-        repo_name: HDR-Development/HDR-DevReleases
-        tag: ${{ steps.package_latest.outputs.release }}
-        overwrite: true
-
-    - name: Display structure of downloaded version
-      run: ls -R && cp hdr_version.txt artifacts
+    # - name: Upload upgrade deletions to previous release
+    #   if: steps.package_latest.outcome != 'failure'
+    #   uses: svenstaro/upload-release-action@v2
+    #   with:
+    #     repo_token: ${{ secrets.RELEASE_TOKEN }}
+    #     file: upgrade_artifacts/deletions.json
+    #     prerelease: true
+    #     make_latest: false
+    #     file_glob: true
+    #     asset_name: deletions
+    #     repo_name: HDR-Development/HDR-DevReleases
+    #     tag: ${{ steps.package_latest.outputs.release }}
+    #     overwrite: true
+
+    # - name: Display structure of downloaded version
+    #   run: ls -R && cp hdr_version.txt artifacts
 
     - name: Upload full package to devreleases
       uses: svenstaro/upload-release-action@v2

.github/workflows/build_prerelease.yml

@@ -1,29 +1,35 @@
 name: build_prerelease
 on:
-  push:
-    branches:
-      - dev
+  workflow_dispatch:
+    inputs:
+      romfs_version:
+        type: string
+        description: 'The romfs version tag to use'
+        required: true
+        default: 'latest'
 
 jobs:
   # bump the version and build the changelog
   version_and_changelog:
     runs-on: ubuntu-24.04
     env:
       GITHUB_TOKEN: ${{ secrets.RELEASE_TOKEN }}
-    outputs: 
+    outputs:
       version: ${{ steps.push_tag.outputs.version }}
       changelog: ${{ steps.github_changelog.outputs.changelog }}
     steps:
-      # fail out if this is not a merge commit
-      - name: ensure merge
-        if: ${{ !startsWith(github.event.head_commit.message, 'Merge') }}
-        run: exit 1
-
       - name: checkout version
         uses: actions/checkout@v4.1.4
-        with: 
+        with:
           fetch-depth: 0
 
+      # fail out if this is not a merge commit
+      - name: ensure merge
+        run: |
+          if ! git log -1 --pretty=%s | grep -q "^Merge"; then
+            exit 1
+          fi
+
       - name: get last merge
         id: last_merge
         shell: bash
@@ -80,14 +86,14 @@ jobs:
       PLUGIN_NAME: hdr
     runs-on: ubuntu-24.04
     needs: version_and_changelog
-    container: 
+    container:
       image: wuboyth/skyline-plugin-builder:latest
     steps:
     # - name: setup python
     #   uses: actions/setup-python@v5.1.0
     #   with:
     #     python-version: '3.9' # Version range or exact version of a Python version to use, using SemVer's version range syntax
-    
+
     - name: checkout version
       uses: actions/checkout@v4.1.4
 
@@ -143,16 +149,16 @@ jobs:
         tag: ${{ needs.version_and_changelog.outputs.version }}
         overwrite: true
         body: ${{ needs.version_and_changelog.outputs.changelog }}
-  
-  # wait for any previous prereleases to complete, since we dont want to step on any 
+
+  # wait for any previous prereleases to complete, since we dont want to step on any
   # full package uploads prior to this one.
   wait_for_previous_builds:
     runs-on: ubuntu-24.04
     needs: upload_to_release
     steps:
       - name: checkout version
         uses: actions/checkout@v4.1.4
-        with: 
+        with:
           fetch-depth: 0
       - uses: ahmadnassri/action-workflow-queue@v1
         with:
@@ -168,10 +174,16 @@ jobs:
       uses: actions/checkout@v4.1.4
 
     - id: romfs_version
-      uses: pozetroninc/github-action-get-latest-release@master
-      with:
-        token: ${{ secrets.RELEASE_TOKEN }}
-        repository: HDR-Development/romfs-release
+      shell: bash
+      run: |
+        if [ "${{ inputs.romfs_version }}" = "latest" ]; then
+          RELEASE=$(curl -s -H "Authorization: Bearer ${{ secrets.RELEASE_TOKEN }}" \
+            https://api.github.com/repos/HDR-Development/romfs-release/releases/latest \
+            | python3 -c "import sys,json; print(json.load(sys.stdin)['tag_name'])")
+          echo "release=$RELEASE" >> $GITHUB_OUTPUT
+        else
+          echo "release=${{ inputs.romfs_version }}" >> $GITHUB_OUTPUT
+        fi
 
     - name: Download romfs
       id: get_romfs
@@ -235,14 +247,14 @@ jobs:
     - uses: actions/download-artifact@v4.1.7
       with:
         name: changelog
-        
+
     - name: Display structure of downloaded changelog
       run: ls -R && cp CHANGELOG.md artifacts
 
     - uses: actions/download-artifact@v4.1.7
       with:
         name: version
-        
+
     # build the lvd files
     # - id: lvd_files
     #   uses: robinraju/release-downloader@v1.7
@@ -400,7 +412,7 @@ jobs:
         repo_name: HDR-Development/HDR-PreReleases
         tag: ${{ needs.version_and_changelog.outputs.version }}
         overwrite: true
-    
+
     # upload the to_beta_deletions.json to the beta for the launcher
     - name: Upload to_beta_deletions.json to prerelease
       uses: svenstaro/upload-release-action@v2