Skip to content

feat(GAT-8541): CRUK API PR#1541

Closed
cocoon02 wants to merge 25 commits intoHDRUK:devfrom
cocoon02:feature/cruk-gateway-api
Closed

feat(GAT-8541): CRUK API PR#1541
cocoon02 wants to merge 25 commits intoHDRUK:devfrom
cocoon02:feature/cruk-gateway-api

Conversation

@cocoon02
Copy link
Copy Markdown

@cocoon02 cocoon02 commented Feb 19, 2026

Screenshots (if relevant)

Describe your changes

Issue ticket link

Environment / Configuration changes (if applicable)

Requires migrations being run?

If not using the pre-push hook. Confirm tests pass:

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added appropriate unit tests
  • I have created mocks for unit tests (where appropriate)
  • I have added appropriate Behat tests to confirm AC (if applicable)
  • I have added Swagger annotations for new endpoints (if applicable)
  • I have added audit logs for new operation logic (if applicable)
  • I have added new environment variables to the .env.example file (if applicable)
  • I have added new environment variables to terraform repository (if applicable)

@cocoon02
Update controllers, config, and add FrankenPHP worker
98b9004 
- Remove .env.example
- Update SearchController, TeamController, and JwtController
- Update JWT config and routes
- Update migration and seeder
- Add FrankenPHP worker script
- Update test files
@cocoon02
Add cancer type filters API and user authentication endpoints
7185b07 
- Add cancer type filters API with hierarchical structure
  - Migration for cancer_type_filters table
  - CancerTypeFilter model with parent/children relationships
  - CancerTypeFilterController with GET endpoints
  - Seeder for populating filter data from JSON
  - Routes for /api/v1/cancer-type-filters endpoints
  - Support for filter_id (string) parameter lookup

- Add user registration and login endpoints
  - Register endpoint with email/password validation
  - Login endpoint with JWT token generation
  - RegisterRequest and LoginRequest form validation classes
  - Updated AuthController with register and login methods

- Add setup documentation for cancer type filters
@cocoon02
Fix search datasets pagination: re-index array after filtering invali…
f86db32 
…d results

- Now builds new validDatasets array and uses array_values() to ensure contiguous keys
- Also removed deleted GitHub workflows, cancer type filter docs, and updated docker-compose.yml
@cocoon02
Add CRUK as auth provider and form hydration fixes
85f200e 
- Auth: add 'cruk' provider for register/login (no SSO)
  - config/constants.php: add cruk to providers
  - RegisterRequest/LoginRequest: optional provider (service|cruk)
  - AuthController: register/login/checkAuthorization use provider
- Form hydration: accept name param, normalize dataTypes 'undefined'/'null'
@cocoon02
GWDM 2.1 seeding: getMetadataV2p1, seeder pool, hdruk_41_dummy_data
f604215 
- MockExternalApis: add getMetadataV2p1() from hdruk_41_dummy_data/dataset_01_gwdm21.json;
  getMetadata() returns V2p1 when config version >= 2.1
- DatasetVersionSeeder: when GWDM >= 2.1, seed from all dataset_*_gwdm21.json files
  (cycle through pool); other versions use factory default (getMetadata)
- hdruk_41_dummy_data: add 20 GWDM 2.1 JSON files with gwdmVersion+metadata structure
  matching gwdm_v2p0 so no runtime metadata wrapping needed
@JamieByrneHDRUK JamieByrneHDRUK changed the title Feature/cruk gateway api feat(GAT-8451): CRUK API PR Feb 20, 2026
loki-sinclair-hdruk
loki-sinclair-hdruk reviewed Feb 20, 2026
View reviewed changes
Comment thread app/Http/Controllers/Api/V1/AuthController.php Outdated
JamieByrneHDRUK
JamieByrneHDRUK reviewed Feb 20, 2026
View reviewed changes
Comment thread app/Http/Controllers/Api/V1/SearchController.php
JamieByrneHDRUK
JamieByrneHDRUK reviewed Feb 20, 2026
View reviewed changes
Comment thread app/Http/Controllers/Api/V1/AuthController.php Outdated
JamieByrneHDRUK
JamieByrneHDRUK reviewed Feb 20, 2026
View reviewed changes
Comment thread app/Http/Controllers/Api/V1/AuthController.php Outdated
JamieByrneHDRUK
JamieByrneHDRUK reviewed Feb 20, 2026
View reviewed changes
Comment thread app/Http/Controllers/Api/V1/FormHydrationController.php Outdated
@cocoon02 cocoon02 force-pushed the feature/cruk-gateway-api branch from 29f1d5f to 8f6dc42 Compare February 20, 2026 11:39
@cocoon02
CRUK review: auth provider CRUK-only, form hydration via CrukSessionH…
396fac2 
…eader middleware, restore dataset search aggs, FormHydration tests
@cocoon02 cocoon02 force-pushed the feature/cruk-gateway-api branch from 8f6dc42 to 396fac2 Compare February 20, 2026 11:41
@cocoon02
Copy link
Copy Markdown
Author

cocoon02 commented Feb 20, 2026

@JamieByrneHDRUK the ci/cd requires approval as I have updated the PR. Thanks

calmacx
calmacx reviewed Feb 20, 2026
View reviewed changes
Comment thread app/Http/Controllers/Api/V1/FormHydrationController.php Outdated
calmacx
calmacx reviewed Feb 20, 2026
View reviewed changes
Comment thread app/Http/Controllers/Api/V1/FormHydrationController.php Outdated
calmacx
calmacx reviewed Feb 20, 2026
View reviewed changes
Comment thread config/jwt.php Outdated
Comment thread database/seeders/omop/ConceptSeeder.php Outdated
Comment thread public/frankenphp-worker.php
dnhdruk
dnhdruk reviewed Feb 20, 2026
View reviewed changes
Comment thread app/Http/Controllers/Api/V1/SearchController.php Outdated
dnhdruk
dnhdruk reviewed Feb 20, 2026
View reviewed changes
Comment thread app/Http/Controllers/Api/V1/SearchController.php Outdated
@cocoon02
Review: JWT secret default, shared FK trait for seeders, remove frank…
3f46de6 
…enphp-worker, simplify SearchController hits
dnhdruk
dnhdruk reviewed Feb 20, 2026
View reviewed changes
Comment thread app/Http/Controllers/Api/V1/SearchController.php Outdated
dnhdruk
dnhdruk reviewed Feb 20, 2026
View reviewed changes
Comment thread app/Http/Controllers/Api/V1/TeamController.php
dnhdruk
dnhdruk reviewed Feb 20, 2026
View reviewed changes
Comment thread app/Http/Controllers/Api/V1/TeamController.php
@JamieByrneHDRUK JamieByrneHDRUK changed the title feat(GAT-8451): CRUK API PR feat(GAT-8541): CRUK API PR Feb 23, 2026
loki-sinclair-hdruk
loki-sinclair-hdruk reviewed Feb 23, 2026
View reviewed changes
Comment thread app/Http/Middleware/CrukSessionHeader.php Outdated
@cocoon02
Form hydration app-level config, remove CrukSessionHeader, ConceptSee…
2175691 
…der updates

- FormHydrationController: schema from config/env only (application-level)
- Remove CrukSessionHeader middleware from routes and Kernel, delete middleware
- Update FormHydrationTest and OpenAPI docs for app-level schema
- ConceptSeeder: use DisablesForeignKeyChecks trait
@cocoon02
Revert FormHydration OpenAPI to original description and params
5b3810a 
- Restore description: 'Retrieves form schema data based on the provided model and version.'
- Restore model/version query params in schema and onboarding endpoints
- Remove CRUK/app-level config wording from Swagger (address calmacx review)
@cocoon02
Form hydration: support request params with config fallback (option 2)
b363de1 
- Schema and onboarding endpoints use name/model and version from request when
  provided, falling back to config (FORM_HYDRATION_*) when omitted
- Keeps existing frontend URL (?name=...&version=...&dataTypes=...&team_id=...)
  working without changes
- Update test_form_hydration_schema_will_fail to expect 400 when invalid
  model is passed (schema provider returns 404)
@cocoon02
Merge branch 'dev' into feature/cruk-gateway-api
e0b1cda
@cocoon02
feat: project grants metadata ingestion
364a0b1
@cocoon02
feat: project grants controller
2f43828
@cocoon02
refactor: extract project grant query logic into service
720d82b
@cocoon02
refactor: extract auth and cancer filter business logic into services
4a9cb4b
@cocoon02
refactor: add auth and cancer filter API resources
1e40908
@cocoon02
refactor: resolve API resources through partner context
78460ba
@cocoon02
fix: make project grant add-column rollback a no-op
6a378aa
@cocoon02
fix: swagger annotation for project grant index
ed92aa2
@cocoon02
refactor: version project grants and harden local API flows
ce00c8c 
Split project grants into stable identity + version rows, update extraction, pivots, resources, and observers. Also improve local DX by allowing x-partner-context in CORS, adding a feature-flags enabled alias endpoint, and guarding the Pennant features migration when the table already exists.
@cocoon02 cocoon02 closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calmacx calmacx calmacx left review comments

@dnhdruk dnhdruk dnhdruk left review comments

@loki-sinclair-hdruk loki-sinclair-hdruk loki-sinclair-hdruk left review comments

@JamieByrneHDRUK JamieByrneHDRUK Awaiting requested review from JamieByrneHDRUK

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cocoon02 @calmacx @dnhdruk @loki-sinclair-hdruk @JamieByrneHDRUK