Skip to content

make suppression factors and eigenval cutoff options optional.#131

Draft
aewallwi wants to merge 1 commit into
mainfrom
suppression_factors_and_eigenval_cutoff_optional
Draft

make suppression factors and eigenval cutoff options optional.#131
aewallwi wants to merge 1 commit into
mainfrom
suppression_factors_and_eigenval_cutoff_optional

Conversation

@aewallwi

Copy link
Copy Markdown
Collaborator

Make the suppression_factors arg in dayenu_filter and _fit_basis_2d/1d optional and also pass tol as an optional arg to these functions. if supression_factors is not provided, then use tol to set the same suppression factors in all fourier windows specified in filter_centers and filter_half_widths.

Also make the eigenval_cutoff and other series termination args in dpss_operator optional. If no cutoff is provided, use a cutoff of 1e-12 for all filter_centers and filter_half_widths.

@aewallwi aewallwi marked this pull request as draft June 11, 2021 06:04
@codecov

codecov Bot commented Jun 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #131 (379f9ee) into main (551b0da) will decrease coverage by 0.33%.
The diff coverage is 77.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   87.81%   87.48%   -0.34%     
==========================================
  Files           7        7              
  Lines        1502     1518      +16     
==========================================
+ Hits         1319     1328       +9     
- Misses        183      190       +7     
Flag Coverage Δ
unittests 87.48% <77.41%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
uvtools/dspec.py 97.00% <77.41%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 551b0da...379f9ee. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant