Skip to content

[Issue #612] Add per-package ci scripts and workspace validation workflow#658

Merged
bryan-thompsoncodes merged 8 commits intomainfrom
612-ci-workspace-scripts
Apr 2, 2026
Merged

[Issue #612] Add per-package ci scripts and workspace validation workflow#658
bryan-thompsoncodes merged 8 commits intomainfrom
612-ci-workspace-scripts

Conversation

@bryan-thompsoncodes
Copy link
Copy Markdown
Collaborator

@bryan-thompsoncodes bryan-thompsoncodes commented Apr 1, 2026

Summary

Changes proposed

Adds a ci script to each workspace package that runs its full validation pipeline, plus root-level shortcuts and a GitHub Action workflow:

Per-package ci scripts added to each package.json:

Package ci script runs
@common-grants/core checks → build → typespec
typespec-versioning-changelog checks → build → test
@common-grants/cli checks → build → test
@common-grants/sdk checks → build → test
website build → checks → test

Note: The website runs build first because Astro requires the build step to generate virtual module types (.astro/types.d.ts, astro:content, etc.) before tsc --noEmit can resolve them. This matches the existing ci-website-preview.yml workflow order.

Root package.json scripts:

  • ci:core, ci:changelog-emitter, ci:cli, ci:sdk, ci:website — filter to individual packages
  • ci — runs all of the above in dependency order

New workflow (.github/workflows/ci-catalog-validation.yml):

  • Triggers on pnpm-workspace.yaml and pnpm-lock.yaml changes, plus workflow_dispatch
  • Installs deps, runs audit, then calls each ci:* in dependency order

Context for reviewers

This addresses Billy's review feedback on PR #647:

  1. Wrap inline pnpm --filter CI steps into reusable root-level scripts (pnpm ci:core, etc.)
  2. Stack [Issue #612] Dependabot and catalog dependency update automation #647 on a smaller, independently testable PR

After merge, the workflow can be tested via workflow_dispatch in the Actions tab. PR #647 will be rebased on top of this branch.

@github-actions github-actions bot added cli Issue or PR related to the @common-grants/cli library website Issues related to the website core Issues related to @common-grants/core library sdk Issue or PR related to our SDKs typescript Issue or PR related to TypeScript tooling ts-sdk Related to TypeScript SDK labels Apr 1, 2026
Astro projects require build to run first to generate virtual module
types (.astro/types.d.ts, astro:content, etc.) before tsc --noEmit
can resolve them. This matches the existing ci-website-preview.yml
workflow order.
@bryan-thompsoncodes bryan-thompsoncodes force-pushed the 612-ci-workspace-scripts branch from d697cdc to 94ec659 Compare April 2, 2026 15:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🚀 Website Preview Deployed!

Preview your changes at: https://cg-pr-658.billy-daly.workers.dev

This preview will be automatically deleted when the PR is closed.

Copy link
Copy Markdown
Collaborator

@widal001 widal001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for adding this as a first step.

I had two small non-blocking comments.

@bryan-thompsoncodes bryan-thompsoncodes merged commit 0f41d61 into main Apr 2, 2026
13 checks passed
@bryan-thompsoncodes bryan-thompsoncodes deleted the 612-ci-workspace-scripts branch April 2, 2026 19:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🗑️ Preview Cleaned Up

The preview for this PR has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Issue or PR related to the @common-grants/cli library core Issues related to @common-grants/core library sdk Issue or PR related to our SDKs ts-sdk Related to TypeScript SDK typescript Issue or PR related to TypeScript tooling website Issues related to the website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security] SPIKE: Research setting up automated dependency updates

3 participants