Fix mobile overlay safe areas - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The shared right sheet and full-screen composer surfaces were positioned against the physical
viewport edge. Unlike the application shell and navigation drawer, they did not reserve the iOS
safe-area insets, so the notch, Dynamic Island, or home indicator could cover important controls.
Impact
Mobile users can reliably dismiss right drawers and composers, and the new-message action row keeps
comfortable spacing above the bottom device inset. Desktop layout remains unchanged.
Validation
WRANGLER_LOG_PATH=/tmp/hqbase-mobile-safe-area-release-check.log CI=true pnpm checkWRANGLER_LOG_PATH=/tmp/hqbase-mobile-safe-area-release-dry-run.log CI=true pnpm deploy:dry-rungit diff --check