Conversation
Restore the HCU Stage B registration dropped during the upstream sync. The required workflow still includes this file, so its missing registration aborted all four partitions before test execution. Verified all 46 required files resolve across the four partitions with run_suite.py --list.
Install the shared pinned sgl-eval CLI in regular and image/wheel modes. Derive FP8 reference scales and one-ULP rounding bounds from the output format. Add the config_value interface to the serving-chat mock. Validated FP8 numeric cases on gfx936, 17 chat tests (one existing skip), installer branch/failure behavior, and actual pinned CLI installation in a disposable container.
Move the shared compression/store call outside cache selection so indexer and unified KV paths cannot skip it. Remove unreachable duplicate selection, preserving idle, BF16/FP4, HiSparse translation and online prefix-state behavior. Add six regression tests with prefill/decode/speculative coverage and run them in required HCU Stage A. Tests reproduce 16 failing subcases before the fix and pass after it.
aivictor0901-tech
left a comment
There was a problem hiding this comment.
该问题已经在下面commit中进行了修复,非常感谢您的提交
4c367db
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CompressorBackendMixin.forward_unified()selects an indexer cache or a unified KV cache, but its compression/store call is nested inside the ordinary compressed-cacheelsebranch. Both earlier branches therefore return without writing the compressed data. The ordinary branch also contains duplicate, unreachable indexer/unified selection.This is a correctness fix for skipped cache writes, not a quantization or performance change. The bug is present in the current HYGON
mainbaseline (0457572a). It was found while investigating long-history retrieval failures in a DeepSeek-V4-Flash-0731 W4A8 deployment.Modifications
The functional fix and tests are isolated in commit
52c2fa05. This branch also carries two independent CI prerequisite commits already submitted in #314/#316: restore the required sampling registration, install the shared pinnedsgl-eval, update the FP8 reference for the selected format, and repair the serving-chat configuration mock. Without these prerequisites, the current base fails required Stage B for unrelated reasons. No performance/operator changes from #314/#316 are included. No reasoning-profile or API compatibility changes are included.Accuracy Tests
Run against the selected checkout with its
pythondirectory onPYTHONPATH:Speed Tests and Profiling
No new throughput claim. Skipping a required write is not a valid performance baseline. Existing kernels, quantization and GEMM backends are unchanged.
Checklist
CI States
Latest PR Test (Base): ❌ Missing
run-cilabel -- add it to run CI tests.Latest PR Test (Extra): ❌ Blocked --
run-ciis required first.