fix(hcu): avoid gfx936 LightOp FP8 MQA zero logits - #51
Open
alexanderbin123 wants to merge 2 commits into
Open
alexanderbin123 wants to merge 2 commits into
alexanderbin123 wants to merge 2 commits into
Conversation
Use the validated AITER Triton FP8 MQA kernel when available and avoid the LightOp 0.6.0 FP8 zero-logit path on gfx936. Keep gfx938 native LightOp behavior and add dispatch contract coverage. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fp8_mqa_logitskernel when available.kv_scale=Nonewhen the AITER module is unavailable, avoiding LightOp 0.6.0's all-zero FP8 result.fp8_ds_mlahandling unchanged.Validation
python -m py_compile vllm_hcu/v1/attention/ops/rocm_aiter_mla_sparse.py tests/runtime_patch/test_lightop_attention_api.pypytest -q tests/runtime_patch/test_lightop_attention_api.py tests/runtime_patch/test_sparse_indexer_loading.py tests/runtime_patch/test_lightop_categorized_api.py🤖 Generated with Claude Code