Open
Conversation
r0m3c
requested changes
Nov 4, 2024
Collaborator
r0m3c
left a comment
r0m3c
left a comment
There was a problem hiding this comment.
Hey Michael, awesome work with the code and with finding the libraries. Below are some change suggestions:
- Do you see this on your end as well? Not sure if it's only me, but ideally we'd want two rows of pictures (1 column), similar to the figma. Also, if possible, the next image(s) that are next in line when a student clicks the arrow, should kind of show a blurred version of them (similar to the screenshot in the third section)
Great work, and let me know if I you need help in anything.
- Leandro G.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.