Release 0.22.3 — build hardening: ad-hoc codesign for locally built macOS binaries#129
Merged
Conversation
…acOS binaries Ad-hoc codesigning for locally built binaries (community contribution — thanks @miskaone, #114): on Apple Silicon, macOS SIGKILLs unsigned Mach-O executables, so a freshly compiled interceptor exited 137 ("Killed: 9") with no output and the daemon never stayed up — every CLI command then returned empty. scripts/build.sh now strips any stale signature and ad-hoc re-signs dist/interceptor, the daemon, and the bridge binary after every compile. Guarded to macOS hosts with codesign present; a no-op on Linux/Windows and CI hosts. Maintainer hardening on top: codesign --verify --strict after each sign so a malformed signature fails the build loudly instead of resurfacing as a silent kill at first run, and a post-build smoke check (dist/interceptor --version) that proves the compiled CLI actually executes on the build host. The ad-hoc path intentionally carries no entitlements: enforcement only applies under the hardened runtime, which ad-hoc signing doesn't enable. Release artifacts are re-signed with the Developer ID identity, entitlements, and notarization by the release pipeline, which is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe version field is bumped from 0.22.2 to 0.22.3 in extension/dist-mv2/manifest.json, extension/manifest.json, and package.json. No other content changes. ChangesVersion Bump
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump + release for the local-build codesigning fix merged in #114 (community contribution by @miskaone, hardened with maintainer follow-ups: post-sign verify + post-build smoke check). See the release commit message for the full change summary.
🤖 Generated with Claude Code
Summary by CodeRabbit