Release 0.22.4 — screenshot render hardening#131
Merged
Conversation
…unt, oversized-render guard DOM-render screenshot hardening (community contribution — thanks @atabisz, #130): render failures now surface a real message for every error shape (Error, DOM Event, string, opaque object) instead of a possible "dom render failed: undefined"; the per-tab screenshot CORS DNR rule is refcounted so concurrent same-tab captures can't tear it down under each other; and the post-render webp re-encode is bounded by the same 30s guard as the render itself. Maintainer hardening on top: pages past the browser's canvas size limits (e.g. 300,000px tall) used to return success with a silent 0-byte image — toDataURL() yields "data:," when the backing store fails to allocate. That is now an actionable error naming --region, --target-max-long-edge, and --scale. And --region is now a real remedy there: region captures crop at rasterize time (crop-sized canvas, offset draw of the decoded SVG), so they work far past the canvas limit and skip the old full-render-then-re-encode crop step. Live-verified end to end: huge page → actionable error; --region on the same page → valid capture; full/region/element/webp parity on normal pages; concurrent same-tab race harness byte-identical across 3 interleavings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughVersion numbers were incremented from 0.22.3 to 0.22.4 in extension/manifest.json, extension/dist-mv2/manifest.json, and package.json. No other changes were made to these files. ChangesVersion Bump
Estimated code review effort: 1 (Trivial) | ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump to 0.22.4 covering the PR #130 adoption (screenshot render hardening, thanks @atabisz) plus the maintainer follow-up: oversized-render guard (no more silent size:0 captures) and raster-time region cropping (--region works past the browser canvas limit). Details in the release commit message.
🤖 Generated with Claude Code
Summary by CodeRabbit