Skip to content

cargo-deny admits the Zlib licence, which foldhash carries under serde_json 1.0.154 - #412

Merged
HackingGate merged 1 commit into
mainfrom
deps/allow-zlib-licence
Oct 22, 2026
Merged

HackingGate merged 1 commit into
mainfrom
deps/allow-zlib-licence

Conversation

@HackingGate

@HackingGate HackingGate commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Bumps serde-saphyr from 1.3.0 to 2.0.0.


updated-dependencies:

  • dependency-name: serde-saphyr
    dependency-version: 2.0.0
    dependency-type: direct:production
    update-type: version-update:semver-major
    ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
https://claude.ai/code/session_01HM96sKSAyDhLk9smu82u5V

Summary by CodeRabbit

  • Chores
    • Updated the list of permitted licenses to include the permissive, OSI-approved Zlib license.

…e_json 1.0.154

serde_json 1.0.154 (#404) depends on foldhash 0.2.0, licensed Zlib, which
the allow list did not name. CI does not run cargo-deny, so main stayed
green while the pre-push `uphold supply-chain` refused every push from it.

Zlib is permissive and OSI approved, with no copyleft and no attribution
required in the binary.

Claude-Session: https://claude.ai/code/session_01HM96sKSAyDhLk9smu82u5V
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 90975e3e-17dc-4449-9afb-ddfbdfaaa19d
📥 Commits

Reviewing files that changed from the base of the PR and between 0051e77 and 92fb286.

📒 Files selected for processing: 1
  • deny.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The license allowlist now includes Zlib. A comment identifies foldhash as the dependency associated with this license.

Changes: License allowlist

Layer / File(s) Summary
Permit the Zlib license
deny.toml
The permitted-license list adds Zlib. A comment identifies foldhash and describes the license.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 92fb2

No actionable merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: allowing the Zlib licence in cargo-deny because foldhash uses it through serde_json 1.0.154.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.84%. Comparing base (0051e77) to head (92fb286).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #412   +/-   ##
=======================================
  Coverage   94.84%   94.84%           
=======================================
  Files          52       52           
  Lines       27217    27217           
=======================================
  Hits        25815    25815           
  Misses       1402     1402           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HackingGate
HackingGate merged commit 92954c9 into main Oct 22, 2026
22 of 23 checks passed
@HackingGate
HackingGate deleted the deps/allow-zlib-licence branch October 22, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants