feat(ui): edit-drawer completeness — all backend values editable (slot/model/profile) + UI-2/20#1020
Merged
Merged
Conversation
thinmintdev
force-pushed
the
fix/wave8b-drawer-completeness
branch
from
cfbdcc8 to
18bc096
Compare
…ofile drawers + UI-2/20 Slot drawer: add vision toggle (+ slot_view enrichment lift & test), idle_timeout_s (Advanced), NPU asr/embed toggles; UI-2 apply-semantics markers (live vs on-Save); UI-20 MTP optimistic-with-revert (parity with Reasoning). Model editor: expose capabilities, backends, rope_freq_base, mmproj, hf_repo/hf_filename, and FIX the wholesale defaults-rebuild that silently cleared unshown ModelDefaults on save (now sends complete defaults; new fields only sent when changed). Profile: fix the device_class='img' dead/corrupting control so ComfyUI img profiles round-trip. All backend endpoints already accepted these — pure UI gaps. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…drawer CI γ-suite caught two overreaches: idle_timeout_s reintroduced a control #587 deliberately removed as clobber-prone/profile-owned, and the UI-2 'applies now' ApplyChip rendered inside the label span (Reasoning -> 'Reasoningapplies now'), breaking label-text assertions and screen-reader labels. Reverted both; kept vision, NPU asr/embed, UI-20 MTP-optimistic, model-editor completeness, and the profile img fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
thinmintdev
force-pushed
the
fix/wave8b-drawer-completeness
branch
from
2f44209 to
c8aceb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 8B — every backend-supported value made editable in the edit drawers
Audit found several typed fields the backend already accepts on its PUT endpoints but that no drawer let you edit. Plus a real data-loss bug and two polish items.
Slot drawer (
slot-modals.jsx+slot_viewenrichment)--mmproj/~0.9 GB when off) — gated to models with an mmproj sidecar; needed aslot_viewenrichment lift (+ test).ge=0, 0 disables eviction).Model editor (
model-modals.jsx)onSaverebuiltdefaultswholesale, silently clearing unshownModelDefaultson every save — now sends the complete merged defaults.Profile drawer (
profiles.jsx)device_class='img'dead/corrupting control so ComfyUI image profiles round-trip (were silently rewritten on edit).Verification
tests/slot_view53 passed; drawer e2e (slots/models/profiles/inference) 34 passed; tree-wide ruff clean.🤖 Generated with Claude Code