fix: GNOME 50 compatibility with Libsoup 3 API - #29
Open
seyhankokcu wants to merge 2 commits into
Open
Conversation
- Add GNOME Shell 50 to supported shell-version in metadata.json - Replace message.request_headers with message.get_request_headers() for Libsoup 3 - Fix prefs.js import path casing for GNOME 45+ module resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"50"toshell-versioninmetadata.jsonso the extension loads on GNOME Shell 50message.request_headers.append()withmessage.get_request_headers().append()— the direct property access crashes on Libsoup 3 (used in GNOME 45+)prefs.jsimport path:resource:///org/gnome/Shell/Extensions/js/extensions/prefs.js→resource:///org/gnome/shell/extensions/prefs.js(case-sensitive path fix for GNOME 45+ module resolution)Test
Tested on GNOME Shell 50.1 — extension loads, usage data displays correctly, settings window opens without errors.
Closes #27, #19