refactor: debrand remaining Fladder Dart symbols, filenames and strings#71
Open
HamadTheIronside wants to merge 4 commits into
Open
refactor: debrand remaining Fladder Dart symbols, filenames and strings#71HamadTheIronside wants to merge 4 commits into
HamadTheIronside wants to merge 4 commits into
Conversation
Foundation slice of #43: a pure, provider-agnostic policy that decides which watched, already-downloaded items to auto-reclaim (oldest-first LRU) to stay within a global storage budget, while never touching unwatched items. Decoupled from SyncedItem/SyncNotifier so it's independently unit-testable; wiring into SyncNotifier and the offline-aware shell UI are follow-up slices of the epic.
Finishes the code-level debrand from #35 (issue #36): renames the last Fladder-prefixed Dart files/classes (FladderConfig, FladderImage, FladderSlider, FladderScrollbar, FladderIcon(Outlined), FladderSnack, FladderLogo, FladderAppBar, FladderTheme, FladderFonts, FladderLocalizations family, FladderItemType, FladderFile, setupFladderWindowChrome, _FladderApp) to their Driftfin equivalents, and updates every import/usage/test accordingly. Also fixes real bugs surfaced by the partial prior rebrand: the auth-link parser only stripped the old fladder:/// prefix so pasted driftfin:/// links failed to parse, notification deep links still built fladder:/// URIs that don't match the driftfin scheme registered in the native manifests, and the auth-link QR overlay referenced a fladder_notification icon asset that no longer exists. Renames the CI prepare-release workflow's bot secrets/git identity to Driftfin naming; no such secret currently exists under either name so this does not change release-workflow behavior, but a DRIFTFIN_BOT_APP_ID / DRIFTFIN_BOT_APP_PRIVATE_KEY GitHub App + repo secrets still need to be configured for that workflow to work. ColorThemes.fladder and its persisted 'Fladder' name are intentionally left untouched (would corrupt users' saved theme preference), as are legitimate upstream attribution mentions of Fladder/DonutWare in docs and CI comments.
…ow scope) The push token used here lacks the workflow scope required to update .github/workflows/*, so the FLADDER_BOT_APP_ID/FLADDER_BOT_APP_PRIVATE_KEY rename from the previous commit can't be pushed. Reverting just that file; the CI bot secret rename (issue #36 item 2) needs to be done by someone with workflow-scoped push access, coordinated with renaming the actual GitHub App + repo secrets (neither FLADDER_BOT_APP_ID nor a Driftfin-named equivalent currently exists as a repo secret).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fladdercode symbols (Dart files/classes, l10n done, CI secrets) #36): renames the lastFladder-prefixed Dart files/classes (FladderConfig,FladderImage,FladderSlider,FladderScrollbar,FladderIcon(Outlined),FladderSnack,FladderLogo,FladderAppBar,FladderTheme,FladderFonts, theFladderLocalizationsfamily,FladderItemType,FladderFile,setupFladderWindowChrome,_FladderApp) to their Driftfin equivalents, updating every import/usage/test.AuthLinkData.parseonly stripped the oldfladder:///prefix, so pasteddriftfin:///auth links failed to parse.NotificationHelpers.buildDetailsDeepLink/buildSeerrDeepLink) still builtfladder://URIs, inconsistent with thedriftfinscheme registered in the Android/iOS manifests.icons/fladder_notification_icon.png, an asset that no longer exists (onlydriftfin_notification_icon.pngdoes).id/nl/zhpasteDriftfinAuthLinkstrings.DRIFTFIN_BOT_APP_ID/DRIFTFIN_BOT_APP_PRIVATE_KEY, then reverts that specific change back toFLADDER_BOT_*in a follow-up commit because pushing workflow file changes needsworkflow-scoped credentials this session doesn't have. Follow-up needed: someone with workflow-scoped push access should apply that rename (noFLADDER_BOT_APP_ID-or-equivalent secret currently exists either way, so this doesn't change current behavior).ColorThemes.fladder/ its persisted'Fladder'name (would corrupt users' saved theme preference) or legitimate upstream Fladder/DonutWare attribution in docs and CI comments.Test plan
flutter analyze— clean (1 pre-existing unrelated warning intool/translation_completeness_check.dart)dart format --line-length 120 --set-exit-if-changedon all changed files — 0 changesflutter test— all 1586 tests pass (3 skipped, 0 failed)dart run build_runner build --delete-conflicting-outputs— regenerated cleanly, no leftoverFladdersymbolsflutter gen-l10n— regenerated cleanly🤖 Generated with Claude Code