Repository navigation
0.13.2: forms show their labels and the privacy checkbox - #25
Merged
Merged
Conversation
Bricks prints form labels only with showLabels and a checkbox's text only from its options. BricksSnap forms set neither, so on a live site the fields had no labels and the required privacy checkbox was missing. Forms now set showLabels and pass the checkbox text as its option under a "Privacy" label. The preview follows Bricks (labels only with showLabels, options, honeypots hidden), and tests cover every form layout. Found while rebuilding a club website on Bricks 2.4.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01APhfigKq7DMdgedQ4Pr9VK
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bricks prints form labels only with showLabels and a checkbox's text only from its options. BricksSnap forms set neither, so on a live site the fields had no labels and the required privacy checkbox was missing. Forms now set showLabels and pass the checkbox text as its option under a "Privacy" label. The preview follows Bricks (labels only with showLabels, options, honeypots hidden), and tests cover every form layout.
Found while rebuilding a club website on Bricks 2.4.2.
Claude-Session: https://claude.ai/code/session_01APhfigKq7DMdgedQ4Pr9VK