Repository navigation
Xcode 27 recommended settings and the last build warnings - #11
Merged
Merged
Conversation
xcodegen wrote LastUpgradeCheck = 1430, so Xcode 27 kept asking to update to its recommended settings. options.xcodeVersion is now 27.0 and the project carries the settings Xcode 27 recommends at the project level: asset symbol extensions, gnu++20 and gnu17, dead code stripping, user script sandboxing and string catalogs preferred. The HLTests-* schemes say LastUpgradeVersion 2700 as well. No target has a run-script phase or C sources, so what is built does not change. Signed-off-by: Hồ Xuân Dũng <me@hxd.vn>
NSWindow.delegate is weak, so the WelcomeWindowDelegate died as soon as it was assigned and windowWillClose never ran: the welcome window stayed recorded as open and the app never went back to .accessory after Pair Phone was closed. WindowPresenter now owns the delegate until the window closes. Signed-off-by: Hồ Xuân Dũng <me@hxd.vn>
…em catalog Xcode names generated asset symbols without the Color suffix, so AccentColor and the accent token both became .accent and HLDesignSystem's generated symbols carried a warning. Only the app catalog needs AccentColor (the global accent color of both app targets reads it from there); the generator no longer writes it into the package catalog, and the test checks the app's AccentColor against the package's accent-fill instead. Signed-off-by: Hồ Xuân Dũng <me@hxd.vn>
…t support moduleAlignedSide is pure arithmetic and is now nonisolated, so the test can call it synchronously without the main-actor warning; the fake phones discard the capability data that accept() returns on purpose. Signed-off-by: Hồ Xuân Dũng <me@hxd.vn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
options.xcodeVersion: "27.0"(xcodegen wroteLastUpgradeCheck = 1430, so Xcode 27 kept asking to Update to recommended settings) and the project-level settings Xcode 27 recommends:ASSETCATALOG_COMPILER_GENERATE_SWIFT_ASSET_SYMBOL_EXTENSIONS,DEAD_CODE_STRIPPING,ENABLE_USER_SCRIPT_SANDBOXING,LOCALIZATION_PREFERS_STRING_CATALOGS= YES,CLANG_CXX_LANGUAGE_STANDARDgnu++20,GCC_C_LANGUAGE_STANDARDgnu17.Tools/make-test-scheme.shwritesLastUpgradeVersion = 2700. No target has a run-script phase or C sources, so nothing built changes. The list comes from Xcode 27'sBase_ProjectSettingstemplate and itsUntitledAppProjectPrototype;DEAD_CODE_STRIPPINGwas the item that made the warning go away.WindowPresentersetwindow.delegateto a fresh object nobody retained (weakdelegate), sowindowWillClosenever ran and closing Pair Phone never took the app back to.accessory. The presenter now owns the delegate (CHANGELOG, Unreleased › Fixed).AccentColor.colorsetinto the package catalog — Xcode derives the asset symbol without the Color suffix, so it clashed with theaccenttoken (#warninginGeneratedAssetSymbols.swift). Both app targets read the global accent color frommacOS/HandLive/Resources/Assets.xcassets, which keeps its copy;ColorSetTestschecks the app'sAccentColoragainst the package'saccent-fill.PairingQRCode.moduleAlignedSideisnonisolated(pure arithmetic, called synchronously from a test); the transport fakes discardaccept()'s result on purpose.Checks
xcodebuild build-for-testingofHLTests-allfrom a clean DerivedData: only the two vendored GRDB warnings remain;HandLive(macOS) andHandLiveiOS(simulator) build without warnings.HLDesignSystemTests,HLMacUITests,HLTransportTests: 268 / 268 passed in Xcode 27.0.generate-design-tokens.py --check: 79 files match;swiftlint lint --strictclean on the changed files.objectVersion = 77, readable by the runner's Xcode 26.Not in this PR:
ThirdParty/GRDBwarnings (vendored) and the deliberateSecKeychainItemDeletedeprecation inLoginKeychain.swift.🤖 Generated with Claude Code