Repository navigation
fix(e2e): start_app resolves the real MainActivity namespace - #10
Merged
Merged
Conversation
PACKAGE moved to the new applicationId com.handlive.android, but start_app's .MainActivity shorthand resolves relative to -n's package segment, not the manifest namespace (still app.handlive.android) -- so am start -n com.handlive.android/.MainActivity pointed at a class that does not exist. Add NAMESPACE and use the full component name. self_test.py: 0 failed.
Play Console screenshots paired against the fake Mac showed its literal "0.0.0 (e2e)" self-reported version in the phone's device-details screen, which reads as test data on a public listing. Default is unchanged; callers staging real-looking screenshots can now pass app_version explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_appused the.MainActivityshorthand againstPACKAGE(com.handlive.android, the applicationId since the Play Store rename in fix(e2e): follow android's new applicationId com.handlive.android #9), but the activity's real namespace is stillapp.handlive.android— soam start -n com.handlive.android/.MainActivitypointed at a non-existent class and every real-emulatore2e.pyrun failed before reaching any scenario.Test plan
tools/.venv/bin/python self_test.py— 0 failede2e.py setup --serial emulator-5554 --apk <debug apk>now gets past install/welcome/notification primer/battery exemption/Pair-a-Device screen (previously failed at the firstam start)