Downgrade to SDK 19 and add a degree suffix to weather temperature (also fix up docs). - #31
Open
pselvana wants to merge 4 commits into
Open
Downgrade to SDK 19 and add a degree suffix to weather temperature (also fix up docs).#31pselvana wants to merge 4 commits into
pselvana wants to merge 4 commits into
Conversation
Move back to SDK 19 to support CM11 (KitKat 4.4)
Add “C” or “F” to temperature line.
Cleaner than the previous comparison.
The root node is missing in the documentation. Also fixing a small typo.
Owner
|
Was there an issue with compiling against SDK 21? |
Author
|
Compiling against SDK 21 was fine. I had a runtime conflict when deploying to a Cynanogen Mod 11 device. SDK 19 worked for both old devices and newer devices. There's quite a few Kitkat 4.4 devices out there that could work well with this project. |
Owner
|
The min SDK is 14. Unfortunately I don't have a KitKat device on hand, but it should install fine on KitKat. I'd rather compile against a modern SDK version. Could you fix any conflicts with CyanogenMod instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on HP Touchpad CM11 (KitKat 4.4.2) and Nexus 5 Lollipop emulator.
Doesn't look like there was any SDK 21 requirements for the project.