Repository navigation
Bring Poster Features to TV Cards, Improve Curated Layouts and Fix Logo Sizing - #72
Conversation
|
Thanks for the PR! The improvements to TV cards, shared card behavior, and curated layouts look good overall. I found one issue that needs to be addressed: 1. [P1] Poster cards lose the IMDb anime rating option In Because the shared hook requires this ID to fetch IMDb ratings for anime, selecting IMDb as the anime-card rating source can still display the MAL rating instead. Please pass Regarding merging: I also have several local commits that haven't been pushed to The PR currently merges cleanly against the remote branch, but integrating it with my local changes produces conflicts in I'll push my pending local commits first so those changes are available on the remote branch. Once they're pushed, we can resolve the overlapping changes while preserving both the existing functionality and the improvements introduced here. After the IMDb rating issue is fixed, the conflicts are resolved, and CI passes, I'll re-review and merge the PR. |
bbbc7e4 to
c78ddbb
Compare
|
I passed animeImdbId: animeImdb |
|
The refactor looks good overall, and the previously reported anime IMDb rating regression is fixed. However, I found a few issues that should be addressed before merging.
Validation: TypeScript typecheck passes. The focused artwork tests pass 7/8 cases; the remaining provider-warning failure is also present on the base branch. Overall, the shared card logic is a good improvement, but I'd recommend fixing these regressions and adding targeted tests for overlay positioning and independent card settings before merging. |
Match curated row sizing to the active poster or TV card style. Use a landscape number badge for TV cards and keep the compact pill for poster cards. Expand curated list grids to use available page width. Pass shared row sizing into the grid so card columns and badges follow the active shape.
Detect logo aspect ratios after loading and apply different compactness thresholds based on intrinsic image width (2.1 for logos up to 500px, 2.7 for logos up to 800px). Keep wide logos at the existing 34px height while allowing compact logos to grow to 54px, improving logo visibility in TV cards.
Match lazy TV card skeletons to the final landscape card height by removing captions that do not appear on loaded TV card style. This prevents rows from shrinking and shifting content below as cards mount during scrolling.
Add a Poster/TV settings switch to the Cards page and give TV cards ScoreStack, Badges, Awards, and hover preview options. - Share card state and score resolution between PosterCard and TvCard while keeping layout-specific rendering, award presentation, and positioning in their respective components. - Extract shared state for Top 10, cinema, rerun, new, DUB, watched, watchlist, and local-library indicators. - Centralize score resolution and badge calculations in useCardScoreState. - Bring TV cards to feature parity for scores, status badges, awards, anime awards, and hover previews. - Add independent Poster and TV card settings, including award tabs, award badges, and no-award modes. - Keep Poster award-tab placement configurable and fix TV award tabs at the top of the card. - Adapt overlay stacking to each layout and prevent collisions among badges, ribbons, awards, bookmarks, and score indicators. - Update card settings previews to match the active layout and settings. - Include miscellaneous fixes and improvements across card components. - Removed `BottomEnd` from `tvCardLogoPos` since that position is now occupied by the score stack.
This covers the layout switch fix, removal of TV’s separate badge limit, and showing all enabled score badges on TV cards.
c78ddbb to
ce6d565
Compare
|
Thanks for the review! I've addressed all five points u mentioned |
Reserve top-right slots for curated TV badges, ribbon and award tabs before rendering score chips. Keep bottom-placed score chips unchanged. Update curated-list badge shape assertions and add TV overlay stacking regression tests.
Keep the top-right bookmark visible with stacked ribbon, scores and badges at standard TV card size. Match the card Settings preview to the real TV bookmark and award positions. Extend overlay regression coverage.
Summary
This PR brings Poster and TV cards closer to feature parity while preserving their layout-specific presentation. It introduces independent settings for each card style, consolidates shared card logic, improves overlay positioning, and updates settings previews.
It also adapts curated lists to the selected card layout, improves TV logo sizing, and fixes landscape skeleton sizing to prevent layout shifts.
Changes
Card settings and feature parity
Shared card behavior
useCardScoreState.Preview and overlay positioning
Curated lists
TV artwork and scrolling
Note: The i18n changes are limited to Arabic for now and are only a small temporary addition to support the new settings labels.
UI Changes
curated list and Grid when cardStyle is set to TV:



After:
Small Compact logo issue (when logo is square or near square it looked too small):
Added scores, badges, awards, and hover previews to TV-style cards, all configurable from Cards settings.
Cards Setting Page: