Skip to content

fix: close next release security gates - #111

Merged
HardcoreMonk merged 2 commits into
mainfrom
agent/next-release-gates
Aug 12, 2026
Merged

fix: close next release security gates#111
HardcoreMonk merged 2 commits into
mainfrom
agent/next-release-gates

Conversation

@HardcoreMonk

Copy link
Copy Markdown
Owner

요약

  • legacy allow_hosts field와 iptables substring matcher를 제거하고 잔존 key를 loud fail-closed 거부
  • PR fix: close release validation gaps #110 사후 review에서 발견된 dm-snapshot 삭제 실패 cleanup을 TDD로 보강
  • npm High 2/Moderate 2를 0건으로 해소하고 Web/secret CI 추가
  • upstream-derived next-version rule과 lifecycle/handoff/공정 보고서 갱신

검증

  • go test ./... -count=1
  • go test -race ./... -count=1
  • daemon/MCP/scheduler named builds, go vet ./..., go mod verify, gofmt -l .
  • govulncheck ./...: reachable 0
  • forced dm failure + TAP/IP continuation targeted tests
  • npm ci, npm run check(0 errors, 기존 warnings 10), npm run build, npm audit --audit-level=moderate(0)
  • bash scripts/secret-scan.sh: tracked tree PASS
  • full KVM e2e_test.sh: All test steps passed; post-inventory TAP/bind/dm/loop/.cow 0
  • Markdown relative links 155건, git diff --check

Release gate

  • tag/release는 생성하지 않음
  • deployment host A1/A2는 접근 불가로 blocker 유지
  • next version number는 post-v0.7.0 upstream tag 부재로 미할당
  • merge 후 main branch protection(required checks + approval 1)을 별도 적용

Lifecycle

  • allow-hosts-removal
  • vm-deletion-failure-cleanup
  • release-governance-hardening

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@HardcoreMonk, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f251487f-2a85-493a-a01b-7966d11324f4

📥 Commits

Reviewing files that changed from the base of the PR and between 794d0ae and 72f7213.

⛔ Files ignored due to path filters (1)
  • web/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (34)
  • .github/workflows/ci.yml
  • CONTEXT.md
  • README.md
  • RELEASE_NOTES.md
  • cmd/goose-daemon/api.go
  • cmd/goose-daemon/api_test.go
  • cmd/goose-daemon/egress_policy.go
  • cmd/goose-daemon/egress_policy_test.go
  • docs/ADR_INDEX.md
  • docs/PUBLIC_RELEASE_BOUNDARY.md
  • docs/adr/0002-egress-sni-transparent-filter.md
  • docs/analysis/12-anvil-project-process-status-review-2026-08-13.md
  • docs/architecture/multi-tenant-roadmap.md
  • docs/architecture/service-logic.md
  • docs/guides/mcp-adapter.md
  • docs/operations/2026-08-13-allow-hosts-removal-handoff.md
  • docs/operations/2026-08-13-release-gate-closure-handoff.md
  • docs/operations/2026-08-13-release-governance-hardening-handoff.md
  • docs/operations/2026-08-13-vm-deletion-failure-cleanup-handoff.md
  • docs/operations/runbook.md
  • docs/operations/security-policy.md
  • docs/superpowers/grill-me/2026-08-13-allow-hosts-removal.md
  • docs/superpowers/grill-me/2026-08-13-release-governance-hardening.md
  • docs/superpowers/grill-me/2026-08-13-vm-deletion-failure-cleanup.md
  • docs/superpowers/plans/2026-08-13-allow-hosts-removal.md
  • docs/superpowers/plans/2026-08-13-release-gate-closure.md
  • docs/superpowers/plans/2026-08-13-release-governance-hardening.md
  • docs/superpowers/plans/2026-08-13-vm-deletion-failure-cleanup.md
  • docs/superpowers/specs/2026-08-13-allow-hosts-removal-design.md
  • docs/superpowers/specs/2026-08-13-release-governance-hardening-design.md
  • docs/superpowers/specs/2026-08-13-vm-deletion-failure-cleanup-design.md
  • internal/storage/snapshot.go
  • internal/storage/snapshot_teardown_test.go
  • web/package.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@HardcoreMonk HardcoreMonk left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수동 actual-diff review 완료: 요구사항 적합성, legacy-key fail-closed, dm failure 뒤 cleanup continuation, error aggregation, TAP/IP 독립 release, npm override/lock graph, CI least privilege, 문서·테스트 정합성을 검토했습니다. blocking/Important finding은 없습니다. CodeRabbit status는 rate limit로 실제 review가 아니므로 독립 approval로 계산하지 않았습니다. repository에 작성자 외 eligible reviewer가 없어 APPROVE는 불가능합니다.

@HardcoreMonk
HardcoreMonk merged commit 60ce239 into main Aug 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant