Repository navigation
The Export menu could never open - #18
Merged
Merged
Conversation
Separate from the dead endpoint: even with a working handler behind it, the menu closed itself the instant it opened. DeckBanner listened for `click` on window with no containment check, and React 18 flushes state and effects synchronously during a discrete event — so the listener was attached while the very click that opened the menu was still propagating, and it closed it again before paint. Fixed to the pattern AvatarMenu in this same file already uses: mousedown, plus a contains() check so a click inside the menu does not dismiss it. Found by driving it: the button reported enabled, on top, and its handler ran, yet .sl-export-menu never appeared in the DOM. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013DCjqvx3L4VKAPnFaPe7YJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Independent of the dead endpoint:
DeckBannerlistened forclickon window with no containment check. React 18 flushes effects synchronously during a discrete event, so the listener attached while the opening click was still propagating and closed the menu before paint.Now mousedown +
contains(), matchingAvatarMenuin the same file.🤖 Generated with Claude Code
https://claude.ai/code/session_013DCjqvx3L4VKAPnFaPe7YJ