mario: the launcher finds the interpreter and the browsers by name - #30
Merged
Merged
Conversation
An MCP stdio server gets a restricted environment from the SDK, so nothing the image exported reaches the launcher, and a hosted sandbox's HOME is made per session, so a home-relative venv never matches one the image installed (both found by the hosted port). The launcher now takes SYSTEMONE_PYTHON if the host set it for the server, then the known venv paths, and picks the first known browser root that holds a chromium-* directory when PLAYWRIGHT_BROWSERS_PATH is unset. Plugin 0.3.2, so a launched harness relaunches onto it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two findings from the hosted System One port, both about the kit's launcher
plugin/bin/mario-env:PLAYWRIGHT_BROWSERS_PATHexported by the image never reachesmario_env.py. It worked on the open-source image only because the launcher's fallback root happened to be the volume path.$HOME/.systemone-venvcandidate never matches a venv the image installed.The launcher now finds both by name:
SYSTEMONE_PYTHONif the host set it for the server, then/data/agent-tools/systemone-venv,/opt/systemone-venvand the home venv; and, whenPLAYWRIGHT_BROWSERS_PATHis unset, the first of/data/agent-tools/ms-playwright,/opt/ms-playwright,/ms-playwrightand~/.cache/ms-playwrightthat holds achromium-*directory. An image that keeps its browsers in one of those places needs no link or export. Plugin 0.3.2, so a launched harness relaunches onto it from the kit page.No change to the environment or the kit's instructions; the released 0.3.1 game logic is untouched.
🤖 Generated with Claude Code