Repository navigation
fix: stabilize LumaCare streaming UX - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Coverage
Pre-Landing Review
Design Review
Eval Results
No prompt-related files changed; evals were not applicable.
Scope Drift
Scope Check: CLEAN. Changes are limited to LumaCare waiting/streaming UX, responsive layout, cancellation safety, tests, and matching documentation.
Plan Completion
No plan file was used for this focused bug fix.
Verification Results
npm test: 17/17 tests pass.npm run build: both Vite builds and server TypeScript checks pass.npm audit --omit=dev --audit-level=high: 0 vulnerabilities.Documentation
demos/02-lumacare/README.md: documents the stable guide viewport, isolated streaming, explicit per-run cancellation, and expanded test coverage.Test plan