Skip to content

fix ci linting and stellar/url asset config#586

Merged
Haroldwonder merged 1 commit into
Haroldwonder:mainfrom
miss-yusrah:feat/transaction
Apr 28, 2026
Merged

fix ci linting and stellar/url asset config#586
Haroldwonder merged 1 commit into
Haroldwonder:mainfrom
miss-yusrah:feat/transaction

Conversation

@miss-yusrah
Copy link
Copy Markdown
Contributor

closes #568
closes #569
closes #574
closes #575

Summary

This PR addresses four small but important reliability issues across CI, frontend navigation state, and Stellar configuration.

Changes

  • add enforced backend linting in CI and a new frontend lint job
  • add minimal frontend ESLint setup and lockfile updates so npm run lint works in CI
  • sync TransactionHistory pagination with the page query param and restore state on browser back/forward navigation
  • move backend Soroban network passphrase selection to env-driven config and validate it against the configured RPC endpoint
  • replace sender-key asset issuance in SendMoneyFlow with issuer addresses from frontend env config

Env updates

Backend:

  • SOROBAN_RPC_URL
  • NETWORK_PASSPHRASE

Frontend:

  • VITE_USDC_ISSUER
  • VITE_EURC_ISSUER

Verification

  • passed: backend npm test -- src/__tests__/stellar-network.test.ts
  • frontend lint now executes, but existing unrelated frontend lint/test issues still remain in the repo and were not cleaned up in this change

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 28, 2026

@miss-yusrah is attempting to deploy a commit to the Harold's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Apr 28, 2026

@miss-yusrah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Haroldwonder Haroldwonder merged commit e5c4778 into Haroldwonder:main Apr 28, 2026
6 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants