fix(frontend): FX rate countdown and expiry warning on review step (#670)#734
Merged
Haroldwonder merged 1 commit intoJun 1, 2026
Merged
Conversation
|
@AnnabelJoe is attempting to deploy a commit to the Harold's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@AnnabelJoe Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #670
Problem
The FX rate was fetched when the user reached the review step and cached for
FX_TTL_MS(30 s). If the user stayed on the review step longer than 30 s, the displayed rate became stale with no indication.Fix
fxFetchedAttimestamp when entering step 4/5.fxExpiredwhen TTL elapses.Rate refreshes in Xs) and a prominent alert (Rate expired — please go back and refresh.) when the rate expires.