Skip to content

fix(#664): add pagination to fetchDisputes in DisputeResolution #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Haroldwonder merged 1 commit into from
Jun 1, 2026
+21 −5
Merged

fix(#664): add pagination to fetchDisputes in DisputeResolution #737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions frontend/src/components/DisputeResolution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,27 +65,36 @@ function parseAuditLogResponse(value: unknown): AuditLogItem[] {
return value;
}

const PAGE_SIZE = 10;

export default function DisputeResolution() {
const [disputes, setDisputes] = useState<DisputeItem[]>([]);
const [loading, setLoading] = useState(true);
const [error, setError] = useState<string | null>(null);
const [auditLog, setAuditLog] = useState<AuditLogItem[]>([]);
const [resolving, setResolving] = useState<string | number | null>(null);
const [confirmOpen, setConfirmOpen] = useState<ConfirmState | null>(null);
const [page, setPage] = useState(1);
const [hasMore, setHasMore] = useState(false);

useEffect(() => {
void fetchDisputes();
void fetchDisputes(1);
void fetchAuditLog();
}, []);

async function fetchDisputes() {
async function fetchDisputes(pageNum: number) {
setLoading(true);
setError(null);
try {
const res = await fetch(`${API_URL}/api/remittances?status=Disputed`);
const res = await fetch(
`${API_URL}/api/remittances?status=Disputed&page=${pageNum}&pageSize=${PAGE_SIZE}`
);
if (!res.ok) throw new Error(`HTTP ${res.status}`);
const data: unknown = await res.json();
setDisputes(parseDisputesResponse(data));
const items = parseDisputesResponse(data);
setDisputes(items);
setPage(pageNum);
setHasMore(items.length === PAGE_SIZE);
} catch (e: unknown) {
setError(e instanceof Error ? e.message : 'Unknown error');
setDisputes([]);
Expand Down Expand Up @@ -129,7 +138,7 @@ export default function DisputeResolution() {
body: JSON.stringify({ in_favour_of_sender: inFavourOfSender }),
});
if (!res.ok) throw new Error(`HTTP ${res.status}`);
await fetchDisputes();
await fetchDisputes(page);
await fetchAuditLog();
} catch (e: unknown) {
setError(e instanceof Error ? e.message : 'Unknown error');
Expand Down Expand Up @@ -224,6 +233,13 @@ export default function DisputeResolution() {
))}
</ul>
)}
{!loading && (disputes.length > 0 || page > 1) && (
<div style={{ display: 'flex', gap: '8px', alignItems: 'center', marginTop: '12px' }}>
<button onClick={() => void fetchDisputes(page - 1)} disabled={page <= 1} aria-label="Previous page">← Prev</button>
<span>Page {page}</span>
<button onClick={() => void fetchDisputes(page + 1)} disabled={!hasMore} aria-label="Next page">Next →</button>
</div>
)}
</section>

<hr style={{ margin: '24px 0' }} />
Expand Down