fix: toast auto-dismiss, dispute tx hash, test-utils export, address validation#740
Merged
Haroldwonder merged 2 commits intoJun 1, 2026
Conversation
…Haroldwonder#688 - Haroldwonder#685 Toast.tsx: add type-based auto-dismiss defaults (error=5s, success=3s) and pause-on-hover with remaining-time tracking - Haroldwonder#686 DisputeResolution.tsx: capture tx_hash from resolve response and display it with a Stellar Expert explorer link - Haroldwonder#687 sdk/src/test-utils.ts: extract makeProposalScVal into shared test utilities file and export it; update governance.test.ts import - Haroldwonder#688 settlements.ts: validate sender/agent are valid Stellar addresses (G... 56 chars) before processing net settlements
|
@Good-Coded is attempting to deploy a commit to the Harold's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Good-Coded Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes four independent issues across the frontend, SDK, and API.
closes #685 — Toast auto-dismiss for error toasts
DEFAULT_DURATIONmap:error=5000ms,success=3000ms,info/warning=4000msToastItemnow uses the type-based default when no explicitdurationis passedonMouseEnterpauses the timer and records remaining time;onMouseLeaverestarts from where it left offcloses #686 — DisputeResolution shows transaction hash after resolution
confirmResolve()now readstx_hashfrom the resolve API responsecloses #687 —
makeProposalScValmoved to shared test utilitiessdk/src/test-utils.tswith the exportedmakeProposalScValhelpergovernance.test.tsnow imports it from../src/test-utils.jsinstead of defining it locallycloses #688 — Stellar address validation in settlements route
STELLAR_ADDRESS_RE = /^G[A-Z2-7]{55}$/regexsenderandagentfields in the per-item validation loop before net settlement processingTesting
governance.test.tsnow uses the shared utility